Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:116866 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 43882 invoked from network); 11 Jan 2022 08:19:55 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 11 Jan 2022 08:19:55 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id D9A1B1804B1 for ; Tue, 11 Jan 2022 01:28:47 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, T_SPF_TEMPERROR autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS199118 195.10.208.0/24 X-Spam-Virus: No X-Envelope-From: Received: from mout-b-206.mailbox.org (mout-b-206.mailbox.org [195.10.208.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 11 Jan 2022 01:28:47 -0800 (PST) Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:105:465:1:4:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-b-206.mailbox.org (Postfix) with ESMTPS id 4JY53d00B0zQkD7; Tue, 11 Jan 2022 10:28:45 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=woltlab.com; s=MBO0001; t=1641893322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7/+LL8YsLDJDGNIKSAMVQQmN2PCsPv/uBd+7fG94qeA=; b=pYNEtMSpO3jmb5j/uRjlYgLMPlqaG+mqgxAO+lzp1ebMtwtLS3liwIALZdV/xJ1avdinED Tc/ehdawCK11FPv1eH9ZPGq4lXvQajWmzSHvyoHa0P8Ei2nGkijChdVKiaOI4hTp+0qJ5E tfzv3o4f+MLyEgG/G2CvBnJEdn4YsRn8Ulzn0t1aTW2oCJ52NIagoFRrOKw4igQRG3jZgP oMP1iydIILLiImCUAhRzCGThn81XnxsMsj/31WXd4mU3z4SwygUbiD7CGvGNUFw/1TbAvb +aS8BM8MbHuO4JWq/Fc16DS4Qj8y5w/xZbXb89cheS/34yyDK6VHfGLKdK9AXw== To: =?UTF-8?Q?Alexandru_P=c4=83tr=c4=83nescu?= Cc: PHP internals References: Message-ID: <7355b2ff-5cb4-aea1-6f37-1dca45003d20@woltlab.com> Date: Tue, 11 Jan 2022 10:28:40 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] RFC [Discussion]: Redacting parameters in back traces From: duesterhus@woltlab.com (=?UTF-8?Q?Tim_D=c3=bcsterhus=2c_WoltLab_GmbH?=) Hi Alex On 1/11/22 4:10 AM, Alexandru Pătrănescu wrote: > As the trace in the exception is in the same format as the one generated > by debug_backtrace(), > do you intend to have the changes affecting debug_backtrace() > and debug_print_backtrace()? My proof of concept patch adjusts the internal 'debug_backtrace_get_args' function which the function that collects the function parameters whenever a back trace is generated (Exceptions, debug_backtrace, debug_print_backtrace). I've added a new example showing debug_backtrace to the RFC. > Also, globally configuring generated exception traces to not include > parameters would solve the issue? > I mean, similarly with how DEBUG_BACKTRACE_IGNORE_ARGS works? This is already configurable with 'zend.exception_ignore_args'. There's a section in the RFC why we believe this to not be a solution: https://wiki.php.net/rfc/redact_parameters_in_back_traces#why_existing_features_are_insufficient Best regards Tim Düsterhus Developer WoltLab GmbH -- WoltLab GmbH Nedlitzer Str. 27B 14469 Potsdam Tel.: +49 331 96784338 duesterhus@woltlab.com www.woltlab.com Managing director: Marcel Werk AG Potsdam HRB 26795 P