Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116862
MIME-Version: 1.0
References: <ded42b3e-3149-1192-0f86-07715fcb7a3e@woltlab.com>
In-Reply-To: <ded42b3e-3149-1192-0f86-07715fcb7a3e@woltlab.com>
Date: Tue, 11 Jan 2022 10:48:33 +0700
Message-ID: <CAEZPtU7OUyymnN1DUhwM5PdTGPZnAgqCy84u6tjDRGBekpidNg@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus=2C_WoltLab_GmbH?= <duesterhus@woltlab.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC [Discussion]: Redacting parameters in back traces
From: pierre.php@gmail.com (Pierre Joye)

Good morning Tim,

On Mon, Jan 10, 2022 at 9:06 PM Tim D=C3=BCsterhus, WoltLab GmbH
<duesterhus@woltlab.com> wrote:

I am not sure it makes sense to make the code so verbose to prevent
users from showing sensitive data as it never stops (next
print_r/var_dump and userland version of them?).

Also sensitive data goes way beyond arguments, GDPR brings a lot of
issues here too. Userland packages like monolog provide filters or
custom output, I think that is where it should be handled.

As a side note, the RFC mentions that zend.exception_ignore_args may
not be configurable on some shared hosters, it is INI_ALL, so even in
the code could change it, any time, back and forth:

<?php
function foo($a) {
        var_dump($a);
        throw new Exception('Thrown');
}
foo('adas');
ini_set('zend.exception_ignore_args', true);
foo('adas');

$ php t.php

string(4) "adas"
PHP Fatal error:  Uncaught Exception: Thrown in /home/pierre/t.php:4
Stack trace:
#0 /home/pierre/t.php(6): foo()
#1 {main}
  thrown in /home/pierre/t.php on line 4

best,
--=20
Pierre

@pierrejoye | http://www.libgd.org