Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116831
Date: Thu, 06 Jan 2022 16:20:41 +0000
To: internals@lists.php.net
User-Agent: K-9 Mail for Android
In-Reply-To: <5a99809d-afda-546c-5a11-a4f0f821aa37@korulczyk.pl>
References: <1641335738.195767637@f174.i.mail.ru> <CA+p1Faa_BAv-DdR7D4Jee2XwNNmVQmmkDf_T_Z_4nAYxWtQPqA@mail.gmail.com> <CAPKYkKy4AtAheYTyS9zn4Bz14x1Eq15amjCcPEBFtvML0cUxGQ@mail.gmail.com> <5a4aebf8-e592-4517-8930-d18b112ef1fd@www.fastmail.com> <5a99809d-afda-546c-5a11-a4f0f821aa37@korulczyk.pl>
Message-ID: <A91D0AC0-D646-4C62-9FF3-EDE8279E43B7@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC: Trait expects interface
From: rowan.collins@gmail.com (Rowan Tommins)

On 6 January 2022 15:21:28 GMT, Robert Korulczyk <robert@korulczyk=2Epl> wr=
ote:
> It should also make it easier for SCA tools to understand=20
>the code since they no longer need to know the whole project to understan=
d that method from trait is implementation of method from interface (which =
is=20
>really tricky right now since it depends on context - trait can at the sa=
me implement and not implement the interface, because it depends on class=
=20
>where it is used)=2E

Your other points make sense, but I don't think this one does - there are =
no implicit interfaces in PHP*, so all any tool cares about is:

1) Does the class declaration say that it implements an interface?
2) Does it actually contain the methods needed to do so, through any combi=
nation of direct implementation, inheritance, and trait usage?

Knowing that a particular trait *could be* used to implement a particular =
interface without further code doesn't really tell the tool anything - it s=
till has to resolve the list of methods on the class itself, and test those=
 against the "implements" clause=2E This is particularly true if the class =
uses the "as" and "insteadOf" clauses when including the trait, which nulli=
fy any promises the trait could make=2E


* other than "Stringable", whose purpose and implementation continue to ba=
ffle me

Regards,

--=20
Rowan Tommins
[IMSoP]