Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116755
MIME-Version: 1.0
References: <CABEW5qdH4w3JJpvZP4pD4R2tTvAFLiPZ_UNBnwA_38cZ4Mf8og@mail.gmail.com>
 <1640910093.890171965@f721.i.mail.ru> <fe1cd7bb-0b28-4e49-32ba-913674d8b6a8@gmail.com>
 <1641095231.967164658@f750.i.mail.ru> <CAEUnE0e9T9_04tdgQc5cyCVAoewDH24xxT4Br1iz35nUevB=5w@mail.gmail.com>
In-Reply-To: <CAEUnE0e9T9_04tdgQc5cyCVAoewDH24xxT4Br1iz35nUevB=5w@mail.gmail.com>
Date: Sat, 1 Jan 2022 22:22:33 -0800
Message-ID: <CAMrTa2FE_Tnf0T4ADhLNGdQVygb+46ripLctfTThdOOtZzam8w@mail.gmail.com>
To: Michael Morris <tendoaki@gmail.com>
Cc: Kirill Nesmeyanov <nesk@xakep.ru>, internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000042658405d4936fa8"
Subject: Re: [PHP-DEV] RFC: Stop to automatically cast numeric-string to int
 when using them as array-key
From: jordan.ledoux@gmail.com (Jordan LeDoux)

--00000000000042658405d4936fa8
Content-Type: text/plain; charset="UTF-8"

On Sat, Jan 1, 2022 at 9:20 PM Michael Morris <tendoaki@gmail.com> wrote:

> I leave the decision making to the maintainers and contribs who do the
> actual work. Hell, I personally don't even use PHP that much these days
> having gotten a job where I focus on writing Cucumber tests in JavaScript
> that run on node.js. I keep up with PHP and this list though cause one
> never knows what the next job will entail. I just dropped out of lurk mode
> to underscore along with others up thread the massive ramifications of what
> is being proposed. As someone who wrote stupid code I can see this
> breaking, tread lightly. And hell, I don't even know how much of that code
> is still in use since I've changed employers many times since it was
> written. This situation is not unique and can create huge headaches for
> companies running projects on legacy code bases.
>

I think a question worth asking is how much of that code is likely to
actually run on PHP X.X if this were done. I don't have an answer to that,
but the kind of code that you're talking about is likely to encounter other
more fundamental problems. For instance, prior to 8.0, doing `$var = $obj +
2` would result in `$var = (int)3;` In PHP 7 this also produced a notice.
In PHP 8, the same line results in a fatal error.

I don't think that the impact would be limited to code that is written
poorly however. There may be code which almost accidentally depends on this
behavior that is in fact well maintained, since it is such a nuanced
problem. To me, this seems like something worth doing, but it might be
something that should wait for a major version.

Jordan

--00000000000042658405d4936fa8--