Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116745
MIME-Version: 1.0
References: <CABEW5qdH4w3JJpvZP4pD4R2tTvAFLiPZ_UNBnwA_38cZ4Mf8og@mail.gmail.com>
 <b6cff282-6565-53ed-c86c-6847a1ae4ae6@gmail.com> <CABEW5qfh4mf3krrxwHp57p_5rK2GSM4c57Jxvoqnm+097JsnNQ@mail.gmail.com>
In-Reply-To: <CABEW5qfh4mf3krrxwHp57p_5rK2GSM4c57Jxvoqnm+097JsnNQ@mail.gmail.com>
Date: Thu, 30 Dec 2021 18:34:18 +0100
Message-ID: <CANS-=pdsyVvyt5RRbGJtnSFw3bPeykz-i_=YnSsJ0k673MPXLQ@mail.gmail.com>
To: Vincent Langlet <mr.vincent.langlet@gmail.com>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000064e3eb05d4607880"
Subject: Re: [PHP-DEV] RFC: Stop to automatically cast numeric-string to int
 when using them as array-key
From: kjarli@gmail.com (Lynn)

--00000000000064e3eb05d4607880
Content-Type: text/plain; charset="UTF-8"

On Thu, Dec 30, 2021 at 5:54 PM Vincent Langlet <
mr.vincent.langlet@gmail.com> wrote:

> Would you still consider this as a massive BC break if
> - The type of the key don't change anymore i.e. array_search(0, ['10' =>
> 0]) will be '10' and not 10.
> - $array[10] still return $array[10] ?? $array['10']
> - $array['10'] still return $array['10'] ?? $array[10]
>
> so it still cast the value when accessing to an array key, but when using
> array_keys/array_search/array_flip/... it won't be cast anymore.
>

"Would you still consider this as a massive BC break"

Yes, because `'10'` from an array flip is not `10` anymore, which means
that using any strict comparisons on those values afterwards will fail if
they assumed it was an int.

--00000000000064e3eb05d4607880--