Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116744
MIME-Version: 1.0
References: <CABEW5qdH4w3JJpvZP4pD4R2tTvAFLiPZ_UNBnwA_38cZ4Mf8og@mail.gmail.com>
 <b6cff282-6565-53ed-c86c-6847a1ae4ae6@gmail.com>
In-Reply-To: <b6cff282-6565-53ed-c86c-6847a1ae4ae6@gmail.com>
Date: Thu, 30 Dec 2021 17:53:50 +0100
Message-ID: <CABEW5qfh4mf3krrxwHp57p_5rK2GSM4c57Jxvoqnm+097JsnNQ@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000bacec905d45fe641"
Subject: Re: [PHP-DEV] RFC: Stop to automatically cast numeric-string to int
 when using them as array-key
From: mr.vincent.langlet@gmail.com (Vincent Langlet)

--000000000000bacec905d45fe641
Content-Type: text/plain; charset="UTF-8"

> It'd not be just a BC break, it'd be an absolutely massive BC break that
> has a potential to break a ton of code and would be extremely hard to
> detect. This is not something that should be changed in an advanced
> version of the language.
>

Would you still consider this as a massive BC break if
- The type of the key don't change anymore i.e. array_search(0, ['10' =>
0]) will be '10' and not 10.
- $array[10] still return $array[10] ?? $array['10']
- $array['10'] still return $array['10'] ?? $array[10]

so it still cast the value when accessing to an array key, but when using
array_keys/array_search/array_flip/... it won't be cast anymore.

--000000000000bacec905d45fe641--