Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116739
MIME-Version: 1.0
References: <CABEW5qdH4w3JJpvZP4pD4R2tTvAFLiPZ_UNBnwA_38cZ4Mf8og@mail.gmail.com>
 <CANS-=peiUx+vYsV-mzEjKQ=W=w2YGrpcDU-1Woj5HOAmQJBFLg@mail.gmail.com> <5ca1c05f-273e-d1f9-5be0-32eee68a6fe1@gmail.com>
In-Reply-To: <5ca1c05f-273e-d1f9-5be0-32eee68a6fe1@gmail.com>
Date: Wed, 29 Dec 2021 18:43:05 +0100
Message-ID: <CABEW5qedvH2b=i6O2HOA22ttsNdFMdFxd21tWkXsEk5=3pe6tA@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000000c0b1205d44c79e5"
Subject: Re: [PHP-DEV] RFC: Stop to automatically cast numeric-string to int
 when using them as array-key
From: mr.vincent.langlet@gmail.com (Vincent Langlet)

--0000000000000c0b1205d44c79e5
Content-Type: text/plain; charset="UTF-8"

> On 29/12/2021 16:58, Lynn wrote:
> > While I'd love for this inconsistency to go away, I also know that this
> is
> > most likely such a big change that it causes months of work and broken
> code
> > because it relies on this behavior. It wouldn't surprise me if this
> > singular change would cause more work than all previous BC breaks
> combined.
>
>
> I was about to say the same thing - this is one of those ingrained
> behaviours that is very hard to analyse use of without running the code,
> so only someone with an extraordinarily good test suite would detect
> that their code was affected before it went live.
>
>
I encounter this issue with an array of zipcode as key, and let's say some
delay as int:
['00001' => 2, '00002' => 5, ..., '10000' => 4, ... ];
If I want all the zipcode with a delay superior to 3, combining array_keys
and array_filter will give me an array of string and int, instead of an
array of only string ; like I would have expected.

Maybe a way to reduce the BC-break would be to say that
- The type of the key won't change anymore i.e. array_search(0, ['10' =>
0]) will be '10' and not 10.
- $array[10] will return $array[10] ?? $array['10']
- $array['10'] will return $array['10'] ?? $array[10]

This would avoid the issue with $products[$_GET['id']] VS
$products[(int)$_GET['id']] and still be a first step in the improvement of
this situation.

--0000000000000c0b1205d44c79e5--