Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:116715 Return-Path: <7snovic@gmail.com> Delivered-To: mailing list internals@lists.php.net Received: (qmail 15599 invoked from network); 22 Dec 2021 08:35:11 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 22 Dec 2021 08:35:11 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 9F3E818054E for ; Wed, 22 Dec 2021 01:39:05 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: <7snovic@gmail.com> Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 22 Dec 2021 01:39:05 -0800 (PST) Received: by mail-io1-f53.google.com with SMTP id q5so2030986ioj.7 for ; Wed, 22 Dec 2021 01:39:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r4Csx4qXSVL14KgMHoI14tpgBiTL487PxUF6URmFBdM=; b=iT0aMo2/tdwFmOeraS4XD06nSuS3QMxtHWwV10d+7NMhA6Mns4VTX24zaB9IX8vST7 Rdtsn2P9YU4ZQFqFca8BkUeQiPLmw4Jan8u9xb/b46HmRcGDBD4pAYYYZVf+CezNpYGr w/q9PAfSqfuf/prL03Z+lyFYF/4fFC3CGMzdImUcxflrrnhBgQ2hTUxMARN308YTn8e+ sH8kbIuUQq/fulgAHXtrhBVBYR9G3gUAxwbjaw+jg9Tcd6Tu+eUJhse/OIg78a79cLor D20UYoYA6bi01TPOWU6tHQIz4Iod9rxCFHvpIojgNljRlZNUHPJXa4k7jKn4ZOi1f521 Y79A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r4Csx4qXSVL14KgMHoI14tpgBiTL487PxUF6URmFBdM=; b=sKkV7YscQHoiI4hHZX0D56cjB4BsWMSJsAvJ4g6ci41L8Ub+AFiaeizPQXs0M3nUis s/es1uUcUKifVnQmMCKKkIwWOWEAM+CNRW/0/D/eK3N1Gz36jS/XAEdHWDvPZnZXvRJk Gh0e89mEBpjqwW5xcYgJYBjUU1/A7WtTakKu/+pQocmBR58f8/c8mY5fXhNa2MbFHUE1 Q7s6qwXWWYzLRvN8MmkrEsXOgAc1aIOxJPEWayQvDRaqNVmwMz2G5qTfy5SRZ0CO+GHh BgKM3VwwvAV+85bqAd5RdCLl9pSHQysZVFpgFxSH9ZILD3jxrggkoGcei2UAAOPXtI6E iuQQ== X-Gm-Message-State: AOAM531vurfs2EBmgL37Rmmry+HBzA/nOBnjjGAXdLwPPVkSbCz5/gf7 Hb72dmSDsPp/HYb8/NxWG9taGgxlzopoMDDrJqw= X-Google-Smtp-Source: ABdhPJwRQZx95kn/r2smA7pfahvU+GNpJXDZIgP9gUAKY/yEN1Lbz+AjF+Q1NWOdZtdqo8/NYr/YH0WFgGGnvRYNxBE= X-Received: by 2002:a05:6638:1348:: with SMTP id u8mr1025775jad.95.1640165943479; Wed, 22 Dec 2021 01:39:03 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Wed, 22 Dec 2021 11:38:52 +0200 Message-ID: To: Levi Morrison Cc: php internals Content-Type: multipart/alternative; boundary="0000000000006f131c05d3b8e4c7" Subject: Re: [PHP-DEV] [VOTE] Add array_group function From: 7snovic@gmail.com (Hassan Ahmed) --0000000000006f131c05d3b8e4c7 Content-Type: text/plain; charset="UTF-8" Hello Levi, maybe, I just was confused while I was rewriting it. any tips would be appreciated. On Tue, Dec 21, 2021 at 5:58 PM Levi Morrison wrote: > On Tue, Dec 21, 2021 at 1:48 AM Hassan Ahmed <7snovic@gmail.com> wrote: > > > > Hello all, > > > > I would like to start a voting phase for this RFC: Add array_group > function > > > > > > Regards, > > > > ~Hassan > > This RFC has mistakes in its opening Discussion section as well as > unnecessarily opinionated language in the introduction, which makes me > doubt that it is ready for voting. Did anyone specifically review the > RFC text for you? > --0000000000006f131c05d3b8e4c7--