Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116639
MIME-Version: 1.0
References: <CABY-MhzJj914nbGG2shGL+LgB9_Lx0qRNTm1AFk7_jGEvTBZNA@mail.gmail.com>
 <CANS-=pchDhu99VA1m_uxioZQ5CV=9QkbpXLwqVS2_RNQe1qmQg@mail.gmail.com> <CABdc3Wqp3MkfrFM2+_7a6uK86m_9_O0BZy7T5nbUP_Q8cM+BBw@mail.gmail.com>
In-Reply-To: <CABdc3Wqp3MkfrFM2+_7a6uK86m_9_O0BZy7T5nbUP_Q8cM+BBw@mail.gmail.com>
Date: Mon, 13 Dec 2021 12:35:23 +0100
Message-ID: <CABY-MhxyDH=yhfa5guPUHeH9+TAPvhMeQ1od4ZAT574ub-98cA@mail.gmail.com>
To: =?UTF-8?Q?Micha=C5=82_Marcin_Brzuchalski?= <michal.brzuchalski@gmail.com>
Cc: Lynn <kjarli@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c708b605d30578b7"
Subject: Re: [PHP-DEV] [RFC] !instanceof operator - reaction measuremen
From: olivernybroe@gmail.com (Oliver Nybroe)

--000000000000c708b605d30578b7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

> The "instanceof" is counterintuitive for me compared to operators.
Hmm interesting, might be possible to go that direction by making
`T_IS_EQUAL` accept `class_name_reference`. I like that, biggest concern
with this is what is the difference (if any) between
```php
$object !=3D=3D MyClass
$object !=3D MyClass
```

> If this isn't possible and `!instanceof` would be adopted, what about the
following in addition to the proposed example?
I definitely agree that those make sense, but I would say that they should
prob. have their own discussion, but would be much easier to get through if
this one would be accepted.

> Why not "not" instead? The "!" in front of "i" in "!implements"
Might be my limited knowledge on the subject, but by using `not`, we are
making `not` a reserved keyword, which I think should be done really
carefully.


Best regards
Oliver Nybroe (he/him)


On Mon, 13 Dec 2021 at 12:19, Micha=C5=82 Marcin Brzuchalski <
michal.brzuchalski@gmail.com> wrote:

>
>
> pon., 13 gru 2021 o 12:10 Lynn <kjarli@gmail.com> napisa=C5=82(a):
>
>> Heya,
>>
>> While I definitely agree with this, and after more than 10 years of PHP =
I
>> still have the tendency to write `if ($object !instanceof MyClass)`
>> anyway.
>> Would it be possible, or would it collide with constants to do the
>> following?
>> ```
>> $object =3D=3D=3D MyClass;
>> $object !=3D=3D MyClass;
>> ```
>> The reason I'm hoping this would be possible, is that I often have
>> brainlag
>> trying to write "instanceof" and I either make several typos, or I end u=
p
>> with "instance" and it takes me an error message to realize I forgot the
>> "of". The "instanceof" is counterintuitive for me compared to operators.
>>
>> If this isn't possible and `!instanceof` would be adopted, what about th=
e
>> following in addition to the proposed example?
>> ```
>> $object implements MyInterface;
>> $object !implements MyInterface;
>> $object extends MyClass;
>> $object !extends MyClass;
>> ```
>>
>
> Why not "not" instead? The "!" in front of "i" in "!implements" is almost
> not visible which IMO could get easily ignored unintentionally.
> Instead constructs like "$foo not implements stdClass" have higher
> visibility and are currently a syntax error.
>
> Cheers,
> Micha=C5=82 Marcin Brzuchalski
>

--000000000000c708b605d30578b7--