Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:116618 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 55247 invoked from network); 9 Dec 2021 21:58:29 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 9 Dec 2021 21:58:29 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 02EF8180507 for ; Thu, 9 Dec 2021 14:59:18 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_05,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Thu, 9 Dec 2021 14:59:17 -0800 (PST) Received: by mail-yb1-f181.google.com with SMTP id f186so17335357ybg.2 for ; Thu, 09 Dec 2021 14:59:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salesforce.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Jgmrm+U1OWXbe4wBJFtK4+EyfPHS/BWwcXm2Gg8aBw=; b=EaNydsF2iatBBJmAz0zqTlej4688V8LFewurZ3t3t14ArFDxkbwFliQDYYoAzAS7PE 8gb8Lq/O9HNm+rliNKbaxcYGuwwMy1gjbAxATGoreNhulPQ/8v+v2npe6tMUVUehFFE1 SvPldmtfNhVoC4lxryCrr/lbg8URJXDFY9L6A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Jgmrm+U1OWXbe4wBJFtK4+EyfPHS/BWwcXm2Gg8aBw=; b=m7QchcYxPLGi/D6aZd2S/xBJHOz0T4i0CdxniHOxZkInsGH6pd2Rjw8d+Lk2VLEAYr AOEURDvo6kub06BR8n3Y9ZidxHVxSyPVjD9A8szxqXQ3uG99N8uxm8B4HWESbl6mYiR7 tnzqx5hRPEdZQp4gIJwrCiAb4e85xDAmsmFvOI4Lc9MLnPGDa0EqDJmSd4kUYryByzOq kIXeiB28GmAODJC7FL8Mg8aZ+wyFrLXTSc30eUoTPs2OqcU/7u//obMzt2oryXLHQ+Hv TOgtkYTFSC58/b3zJW9+EQJcCO6H6DYMn7fQwzfCDo/LLbf3UpCsFtpxuLMbzD6NB4BD h1jw== X-Gm-Message-State: AOAM530Hp5LVphcjHs+WtsVmQn0E/SJUb2ZnIVK1AVfzRpdrMe4TxI79 u9khIxEM23V74K49dE584jVyUlWefGjTV6X8dckk+m1fRxg= X-Google-Smtp-Source: ABdhPJxFrJmI+FRKSvRosinKoQd2B/TnUOyAo6KaHaUH4TUxPg0bHzba4SEnQ3cUM3qcQNKvUn3iAAN5OuJ2veNfR14= X-Received: by 2002:a05:6902:1209:: with SMTP id s9mr10577240ybu.172.1639090757042; Thu, 09 Dec 2021 14:59:17 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Reply-To: David Zuelke Date: Thu, 9 Dec 2021 23:59:06 +0100 Message-ID: To: Dan Ackroyd Cc: PHP internals Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] Why do PHP 8.1 extensions need PHP headers during make install (worked in <8.1)? From: internals@lists.php.net ("David Zuelke via internals") Ahhh okay that explains where this change is coming from. Thanks a lot, Dan! I wonder if this side effect ("all dependencies are iterated also during "make install") is intentional. Maybe Niki can chime in on GitHub; I'll ping him there, as well as the original author. Thanks a lot! David P.S. regarding your earlier comment on the '-include' directive - that allows the actual file you're specifying there to be missing; not any file names listed inside it - the purpose is to optionally let generic/templated Makefiles specify a file that lists additional includes, but making that file itself optional. On Thu, Dec 9, 2021 at 8:41 PM Dan Ackroyd wrote: > > On Thu, 9 Dec 2021 at 19:28, Dan Ackroyd wrote: > > > Is this intentional? If so, could someone explain the purpose of the change? > > > > Probably to make the build process less flaky, by explicitly checking > > dependencies, so that there are fewer instances of "stuffs not > > working.....I guess I'll do a make clean and see if that helps". > > > > And of course I find the commit just after sending previous email: > > commit - https://github.com/php/php-src/commit/c4d508c2bc09860bfa15b7f520e0ba68425acfc1 > reasoning - https://github.com/php/php-src/pull/6693 > > cheers > Dan > Ack