Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116610
MIME-Version: 1.0
References: <CANzZr6kgZCF4DRKOnMTQr5gZ1LRQ2mMFn1OottwQR87qL=t25g@mail.gmail.com>
 <CAF+90c9i90FLNaL=bvN4=L0iJbb4RxGrfU-vt7Q09ZvG+gYsjA@mail.gmail.com>
 <CANzZr6=g3fYiLd5Wu-rfVSJEScC+NJnSKmtYzDULysJbe9qOnA@mail.gmail.com>
 <CAF+90c-uSTqkJg2hSvCvyvg+KxV8p4Asne7mLG_hb-MyUOZ2Nw@mail.gmail.com> <CANzZr6=rnHzZix0pnDLM+d=i+EkrF_KiijX3-7vgwxNp0Ecb0A@mail.gmail.com>
In-Reply-To: <CANzZr6=rnHzZix0pnDLM+d=i+EkrF_KiijX3-7vgwxNp0Ecb0A@mail.gmail.com>
Date: Thu, 9 Dec 2021 20:08:41 +0000
Message-ID: <CA+kxMuTrwnWpFc4peh7-1=gYEHzCY76gJhEeQBT8HJ1HDCG7Vg@mail.gmail.com>
To: Jeremy Mikola <jmikola@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Automatic implementation of Stringable may conflict
 with old, untyped arginfo declarations
From: Danack@basereality.com (Dan Ackroyd)

On Wed, 8 Dec 2021 at 16:02, Jeremy Mikola <jmikola@gmail.com> wrote:
>
>
> We haven't explored using stubs, but I'll keep that in mind. ...
>  (which we plan to do since we finally dropped support for PHP
> 7.1).
>

FYI, the stub files maintain #ifdef info through their processing,
which allows some useful shenanigans* e.g.:

https://github.com/Imagick/imagick/blob/86d95fed787d60db110ccfeb2d89ec53f1d1f5f7/Imagick.stub.php#L168-L182
https://github.com/Imagick/imagick/blob/86d95fed787d60db110ccfeb2d89ec53f1d1f5f7/Imagick_arginfo.h#L748-L778

So the stubs are used to generate arg info for Imagick from PHP 5.4 to
8.1, across lots of versions of ImagickMagick.

I'm finding managing function signatures in a PHP file, in standard
PHP format, is a lot nicer than maintaing that info in C files.

cheers
Dan
Ack

* Though, tbh, I wished I'd known about /** @generate-legacy-arginfo
*/ before doing some of the hacks in the Imagick regen_arginfo.sh
script.