Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116591
MIME-Version: 1.0
References: <CAA6+j4tx8ZadUi_P7y-o_U0eN+UsW38FvBYBk_EDHTpdMTTLVQ@mail.gmail.com>
 <7c4411c8-8bf6-36f1-36f8-1a7391c2a3d7@gmx.de> <CAEZPtU7aHBqrBEgeHTaRZCX0rA0HUdxE25K16xw5Veh6Nq9yxw@mail.gmail.com>
In-Reply-To: <CAEZPtU7aHBqrBEgeHTaRZCX0rA0HUdxE25K16xw5Veh6Nq9yxw@mail.gmail.com>
Reply-To: Yannis Guyon <yguyon@google.com>
Date: Wed, 8 Dec 2021 19:22:42 +0100
Message-ID: <CACz+aBDOQB84B9W5hxdooArD4q+eC03sA+O7KSD=1iM-9QN4=A@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: "Christoph M. Becker" <cmbecker69@gmx.de>, Ben Morss <morss@google.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000002321305d2a694a1"
Subject: Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()
From: internals@lists.php.net ("Yannis Guyon via internals")

--00000000000002321305d2a694a1
Content-Type: text/plain; charset="UTF-8"

>
> On a general principle, I understood that bundling libs should be avoided.
>

libavifinfo was designed more as a copy-pastable snippet than a library.
Unfortunately AVIF is complex and avifinfo.c is lengthier than expected,
although
I believe 700 lines are still reasonable and way below a library's scale.

I am not totally sure aviinfo is stable enough to be bundle either way.
>

What would you call "stable enough"?
There is a test
<https://aomedia.googlesource.com/libavifinfo/+/refs/heads/main/tests/avifinfo_test.cc>,
it is currently internally fuzzed
<https://aomedia.googlesource.com/libavifinfo/+/refs/heads/main/tests/avifinfo_fuzz.cc>
and
was successfully run on more
than 60k crawled AVIF images. I do not plan on modifying or testing it
further
until the AVIF format changes.

The format will  be widely used in a near future so i would rather allow it
> if libavinfo js available rather than  bundling it.


What would be the pros and cons of using a javascript version of libavifinfo
rather than the C one?

Thanks,
Yannis

--00000000000002321305d2a694a1--