Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116590
MIME-Version: 1.0
References: <CAA6+j4tx8ZadUi_P7y-o_U0eN+UsW38FvBYBk_EDHTpdMTTLVQ@mail.gmail.com>
 <7c4411c8-8bf6-36f1-36f8-1a7391c2a3d7@gmx.de>
In-Reply-To: <7c4411c8-8bf6-36f1-36f8-1a7391c2a3d7@gmx.de>
Date: Wed, 8 Dec 2021 23:02:33 +0700
Message-ID: <CAEZPtU7aHBqrBEgeHTaRZCX0rA0HUdxE25K16xw5Veh6Nq9yxw@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Ben Morss <morss@google.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d6f0e605d2a49e48"
Subject: Re: [PHP-DEV] Re: Finishing AVIF support in getimagesize()
From: pierre.php@gmail.com (Pierre Joye)

--000000000000d6f0e605d2a49e48
Content-Type: text/plain; charset="UTF-8"

Good evening,

On Wed, Dec 8, 2021, 6:40 PM Christoph M. Becker <cmbecker69@gmx.de> wrote:

> On 01.12.2021 at 00:52, Ben Morss via internals wrote:
>
> l
>
> Thanks for your and your colleague's work!  It's highly appreciated.
>
> Anyhow, a respective PR[1] has been submitted now, and I'm in favor of
> bundling libavifinfo.  I'm not too concerned regarding the additional
> size of the PHP binaries which would result by linking it in, but if
> others are, we could still introduce a configuration option (e.g.
> `--with-libavifinfo`).
>
> Thoughts?  Objections to bundling libavifinfo at all?
>
> [1] <https://github.com/php/php-src/pull/7711>
>

On a general principle, I understood that bundling libs should be avoided.

I am not totally sure aviinfo is stable enough to be bundle either way.

The format will  be widely used in a near future so i would rather allow it
if libavinfo js available rather than  bundling it.

best,
Pierre

>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--000000000000d6f0e605d2a49e48--