Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116587
Message-ID: <7c4411c8-8bf6-36f1-36f8-1a7391c2a3d7@gmx.de>
Date: Wed, 8 Dec 2021 12:40:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: de-DE
To: Ben Morss <morss@google.com>, PHP internals <internals@lists.php.net>
References: <CAA6+j4tx8ZadUi_P7y-o_U0eN+UsW38FvBYBk_EDHTpdMTTLVQ@mail.gmail.com>
In-Reply-To: <CAA6+j4tx8ZadUi_P7y-o_U0eN+UsW38FvBYBk_EDHTpdMTTLVQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: Finishing AVIF support in getimagesize()
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 01.12.2021 at 00:52, Ben Morss via internals wrote:

> Earlier this year, I added support for AVIF images
> <https://github.com/libgd/libgd/pull/671> to libgd
> <https://github.com/libgd/libgd>. My ultimate goal was to bring support =
for
> this new image format to PHP, so that the world's top CMSs could let sit=
es
> serve AVIFs. A few of you kindly guided me as I made my first contributi=
ons
> to the PHP codebase, propagating libgd's new AVIF support
> <https://github.com/php/php-src/pull/7026> into PHP's bundled gd fork,
> and adding
> AVIF awareness <https://github.com/php/php-src/pull/7091> to non-gd
> functions like getimagesize() and imagecreatefromstring().
>
> Unfortunately, when I worked on getimagesize(), AVIF experts advised tha=
t
> there was no compact, reliable way to determine the size of an AVIF imag=
e
> without relying on an external library like libavif. We decided
> <https://github.com/php/php-src/pull/5127#issuecomment-799825277> that i=
t
> was useful to return the information that a given image was an AVIF, but
> simply to return 0 for the actual dimensions and other details. The user
> would simply need to decode the image to determine this information.
>
> Of course, users would really like
> <https://github.com/php/php-src/pull/5127#issuecomment-976241397> to use
> getimagesize() to return the actual size. So a colleague has kindly
> created standalone
> code <https://aomedia-review.googlesource.com/c/libavifinfo/+/148321> (t=
hat
> doesn't depend on libavif) to do this, with the goal of adding it to PHP=
.
>
> The code comprises several hundred lines. But - it works, and it works w=
ell.
>
> Would it be ok to submit a PR containing this code to add this
> functionality? Or does someone have a superior approach?

Thanks for your and your colleague's work!  It's highly appreciated.

Anyhow, a respective PR[1] has been submitted now, and I'm in favor of
bundling libavifinfo.  I'm not too concerned regarding the additional
size of the PHP binaries which would result by linking it in, but if
others are, we could still introduce a configuration option (e.g.
`--with-libavifinfo`).

Thoughts?  Objections to bundling libavifinfo at all?

[1] <https://github.com/php/php-src/pull/7711>

=2D-
Christoph M. Becker