Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116577
MIME-Version: 1.0
References: <CAL8UiQVrhOOivTL4LX+j-UXe=Scn_JwJ=zQwxga+K9kjWa2weA@mail.gmail.com>
 <CADyq6sJkLY2exHAczq9wXoPccDydnMaggfKCNSrP-ziHwhBmEA@mail.gmail.com>
 <61ac9759.1c69fb81.b0241.1e6fSMTPIN_ADDED_MISSING@mx.google.com>
 <d7d07ab1-b2cf-1391-30cf-614d71cc16b7@gmail.com> <CAL8UiQVvyze26W4ePwUm+EB5A95-Mu0-wgcKOqRcrSRw0kgxEA@mail.gmail.com>
 <268F5B4F-4770-48AA-B212-DE23116BCF4C@gmail.com>
In-Reply-To: <268F5B4F-4770-48AA-B212-DE23116BCF4C@gmail.com>
Date: Mon, 6 Dec 2021 21:37:28 +0200
Message-ID: <CAL8UiQVmvab_cDs0ON7+fE+7dccST+=tCBgtpK+E9N-0Bzrxww@mail.gmail.com>
To: Claude Pache <claude.pache@gmail.com>
Cc: Rowan Tommins <rowan.collins@gmail.com>, internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC [Discussion] array_column results grouping
From: 7snovic@gmail.com (Hassan Ahmed)

The named arguments are a great thing to set in mind, but I think that
we will go to complicate it with optional arguments.
there is a comment on the PR that asks for another option to preserve
the sub-array index to be the new array index. also with the comments
by `Hendra Gunawan` in mind. adding a new optional argument will make
it harder to expand it in the future.

Hassan Ahmed

On Mon, Dec 6, 2021 at 12:24 PM Claude Pache <claude.pache@gmail.com> wrote=
:
>
>
>
> Le 6 d=C3=A9c. 2021 =C3=A0 09:44, Hassan Ahmed <7snovic@gmail.com> a =C3=
=A9crit :
>
> Hello Folks, Thanks a lot for your feedback, as already mentioned in
> the RFC and as mentioned by Rowan too a new function is an option. I
> think that mostly we will go with the new function option.
> I will try to edit the PR to add a new function, does there any
> suggestions/naming conventions for the new function? a colleague
> suggested being `array_group_by` and Hendra already suggested to be
> `array_column_group` which is good too.
>
> Regards,
> Hassan
>
>
>
> Now that we have named arguments, the issue of long and complicated list =
of arguments is considerably weaken, since you can write:
>
> array_column($foo, column_key: 'name', grouping: true);
>
> in lieu of:
>
> array_column($foo, null, 'name', true)
>
> Also, an alternative to a new function, is reusing the same function with=
 an alternative signature, as it was done for setcookie:
>
> https://www.php.net/manual/fr/function.setcookie.php
>
> I have no opinion about which of the three approaches (new parameter, sam=
e function with alternative signature, new function) is better; I just ment=
ion the various alternatives.
>
> =E2=80=94Claude