Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116571
Message-ID: <d7d07ab1-b2cf-1391-30cf-614d71cc16b7@gmail.com>
Date: Sun, 5 Dec 2021 14:02:03 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: internals@lists.php.net
References: <CAL8UiQVrhOOivTL4LX+j-UXe=Scn_JwJ=zQwxga+K9kjWa2weA@mail.gmail.com>
 <CADyq6sJkLY2exHAczq9wXoPccDydnMaggfKCNSrP-ziHwhBmEA@mail.gmail.com>
 <61ac9759.1c69fb81.b0241.1e6fSMTPIN_ADDED_MISSING@mx.google.com>
In-Reply-To: <61ac9759.1c69fb81.b0241.1e6fSMTPIN_ADDED_MISSING@mx.google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] RFC [Discussion] array_column results grouping
From: rowan.collins@gmail.com (Rowan Tommins)

On 05/12/2021 10:41, Mark Randall wrote:
> On 04/12/2021 14:21, Marco Pivetta wrote:
>> Gonna vote `no` on this: please design new/dedicated functions, 
>> rather than
>> expanding optional parameters.
>
>
> I would vote no for the same reason.


Since this is explicitly an open question in the current RFC draft, it 
seems a bit premature to talk about voting, rather than encouraging the 
RFC to develop in a particular direction.

For what it's worth, I agree that a new function is probably better 
here, because the argument list of array_column is already quite 
complicated. A new function also leaves the way open to add more 
functionality, such as the "reducer" callback suggested by Hendra 
Gunawan; I don't think that's needed in the first implementation, though.

In general, I like the proposal - like array_column itself, it's one of 
those things that's fairly _simple_ to do in userland, but also fairly 
_often_ done, so compacting it to a neat function call seems useful.

Regards,

-- 
Rowan Tommins
[IMSoP]