Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116554
Return-Path: <bwetherington@grokability.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 54223 invoked from network); 2 Dec 2021 06:03:46 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 2 Dec 2021 06:03:46 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id 750EE1804BC
	for <internals@lists.php.net>; Wed,  1 Dec 2021 23:02:39 -0800 (PST)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
	RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.2
X-Spam-ASN: AS15169 209.85.128.0/17
X-Spam-Virus: No
X-Envelope-From: <bwetherington@grokability.com>
Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Wed,  1 Dec 2021 23:02:38 -0800 (PST)
Received: by mail-qv1-f53.google.com with SMTP id i13so24134071qvm.1
        for <internals@lists.php.net>; Wed, 01 Dec 2021 23:02:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=grokability.com; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=RLpRUPTN66q8ewqQu/xOAHB3s0Ynkm2aY8V14MzBTlY=;
        b=EPlq+pz5q4F8TtW+vcBHbeQqEr5/+R/f8tQ0NuOB9k06pSBn+R0RBE4kofj35X88TL
         D+f+6JqL9ABR0LUH/bICZx+x2UWUU+Y4Ln+kN41DjdaGZmIs2SSIxVHhEaTRQVtM5r13
         8S+GftVk48HiylNHGmYMRePXBOir1LvNiIx1LYbxpL08OquR7lKOpltfgGYBMB4VWfHZ
         PEhj9MVkgZhwAUkNsZDuVRZNRvOOcT8omiZwTmxtUnGAZUXt/suu0/qaHS/iynC1exr8
         eA0n+OpMuYa9aSHjgTfCj1OEhZ7/6MJREmmcDYhDAS2n4IEenhs/xx32rn2UGIaoVKSz
         o+8A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=RLpRUPTN66q8ewqQu/xOAHB3s0Ynkm2aY8V14MzBTlY=;
        b=sLAHxf4GVx8VRWW/ysGdIv45Zgu5z0K/HBM7eU2XlrexbvSgV3ZdSHmL3ZGaFPerKI
         j5tkbMjB5KzQ3UVYXPrRItB+UGaCv4oMdl5kPoTVPh4f9eFv79a8Oa3Mb5wjHGor7k0a
         Z4VItQClSyLTkLPqlMgt5vQl4a1gWP9H9Ce7igyU2A3FtQDbY28/xxA8/ZVg67vUSPu1
         KslKEwzuVfQddoYeOFAM/QHPOev7QcneQlNW/l1PFBBuGy3OaO8Q5ZM0oyk1GTjAn3EO
         nHGrlRYF7zkjIGxyfhR6DYLbfRZ+a8N8TggOgJUy7y9NCk95IccFeCc9mB9R40LkFDDX
         D57Q==
X-Gm-Message-State: AOAM530gE+G94N0zDVPd/OzqXouvoJWzvYUtXbhw64UzD9R2p+Y2Tfid
	m+KANAXPIJhZ5fVoJrIeK0vsFyk5/A+OeNWhgij5hQ==
X-Google-Smtp-Source: ABdhPJzn06E3yR2rjTtQrpQuYRPE65+zeAMjOcX72MHS4ijp2rrTzD+cqmD/48gENzG0sD2683kVcnqhn6dd9Y7c61U=
X-Received: by 2002:a05:6214:1513:: with SMTP id e19mr11497242qvy.124.1638428558118;
 Wed, 01 Dec 2021 23:02:38 -0800 (PST)
MIME-Version: 1.0
References: <CALp5e-8xoj-RTcvmvDZ68c0pgAJBUcKhkLwZxNLspYhY6G6qEw@mail.gmail.com>
 <CAGBsUrcVjNmOJk8DnOmWzfmr5vVgjWbDzj-bYv1QGDXSdJz=Cw@mail.gmail.com>
 <CALp5e-8=sbQo1rCNW_Hf0Tw6v4PtPss7L9GoHq6XTev8Wh97=g@mail.gmail.com>
 <CA+kxMuRdb2DDNteEn1Os7T5dc-5gUCQ=eTB9Bfr7AA5bb4q2jg@mail.gmail.com>
 <CALp5e-92Te1ZmSKXubG45Fw1nznyiN2sN_LmycYZ1Dxb2YFQ4g@mail.gmail.com>
 <CAESVnVqD+9w=_qhh2ADD9WM0YqmGP_X0Qpfd8qZonbP2wZ4G_Q@mail.gmail.com>
 <CALp5e--CbO1O72WPY7Efyjtm1=HAF9TRsq-a34B04Ed6S_R9wg@mail.gmail.com>
 <CALp5e--qn4bGJJ0KOXM7tCeYOyxvG9OSm6MHx6miKugHjiJPew@mail.gmail.com> <CAESVnVpPAfdeyHV8+F5sLK4sXQzM0cYqPv6dLAcM8ov7pTwdYA@mail.gmail.com>
In-Reply-To: <CAESVnVpPAfdeyHV8+F5sLK4sXQzM0cYqPv6dLAcM8ov7pTwdYA@mail.gmail.com>
Reply-To: Brady Wetherington <bwetherington@grokability.com>
Date: Wed, 1 Dec 2021 23:02:27 -0800
Message-ID: <CALp5e--rP44kUpo5v5TW-Bwu-BchOZ5v0wubm8NRwQsXqKES4g@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: Dan Ackroyd <Danack@basereality.com>, Kamil Tekiela <tekiela246@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties
From: internals@lists.php.net ("Brady Wetherington via internals")

On Wed, Dec 1, 2021 at 9:16 PM Sara Golemon <pollita@php.net> wrote:
>
> On Tue, Nov 30, 2021 at 10:18 PM Brady Wetherington <bwetherington@grokab=
ility.com> wrote:
>>
>> >>> =E2=80=A6It's been merged to master, so you could stand up a build n=
ow and point to the many deprecation warnings you're expecting.  I'm not sa=
ying send PRs to fix them all, just show real impact rather than theoretica=
l guessing. =E2=80=A6
> ...
> Does it look like there's any sensitive information in these log entries?=
  You mentioned they were only in external dependencies so I'm thinking/hop=
ing not.  What I'm getting at is: Would you mind sharing those raw logs som=
ewhere. I'm sure someone will find it a fun opportunity to make some pull r=
equests in a variety of projects.

Nope, not at all. Here I extracted out just the specific deprecations
and added counts so anyone can see how many times a deprecation
warning came up. Please do note that it is very likely that newer
versions of these libraries may have already resolved the issues, I
haven't bothered yet to try and upgrade to the latest versions.




uberbrady@GrokBook-Pro-Black snipe-it % cut -d " " -f 4-
storage/logs/deprecations.log|sort |uniq -c
  10 Creation of dynamic property
Barryvdh\Debugbar\DataCollector\ViewCollector::$name is deprecated in
/Users/uberbrady/Documents/grokability/snipe-it/vendor/barryvdh/laravel-deb=
ugbar/src/DataCollector/ViewCollector.php
on line 24
  10 Creation of dynamic property
Barryvdh\Debugbar\DataFormatter\QueryFormatter::$cloner is deprecated
in /Users/uberbrady/Documents/grokability/snipe-it/vendor/maximebf/debugbar=
/src/DebugBar/DataFormatter/DataFormatter.php
on line 23
  10 Creation of dynamic property
Barryvdh\Debugbar\DataFormatter\QueryFormatter::$dumper is deprecated
in /Users/uberbrady/Documents/grokability/snipe-it/vendor/maximebf/debugbar=
/src/DebugBar/DataFormatter/DataFormatter.php
on line 24
  30 Creation of dynamic property
Barryvdh\Debugbar\DataFormatter\SimpleFormatter::$cloner is deprecated
in /Users/uberbrady/Documents/grokability/snipe-it/vendor/maximebf/debugbar=
/src/DebugBar/DataFormatter/DataFormatter.php
on line 23
  30 Creation of dynamic property
Barryvdh\Debugbar\DataFormatter\SimpleFormatter::$dumper is deprecated
in /Users/uberbrady/Documents/grokability/snipe-it/vendor/maximebf/debugbar=
/src/DebugBar/DataFormatter/DataFormatter.php
on line 24
  10 Creation of dynamic property
DebugBar\DataFormatter\DataFormatter::$cloner is deprecated in
/Users/uberbrady/Documents/grokability/snipe-it/vendor/maximebf/debugbar/sr=
c/DebugBar/DataFormatter/DataFormatter.php
on line 23
  10 Creation of dynamic property
DebugBar\DataFormatter\DataFormatter::$dumper is deprecated in
/Users/uberbrady/Documents/grokability/snipe-it/vendor/maximebf/debugbar/sr=
c/DebugBar/DataFormatter/DataFormatter.php
on line 24
  12 Creation of dynamic property
Illuminate\Database\MySqlConnection::$readWriteType is deprecated in
/Users/uberbrady/Documents/grokability/snipe-it/vendor/laravel/framework/sr=
c/Illuminate/Database/Connection.php
on line 1368
   4 class_exists(): Passing null to parameter #1 ($class) of type
string is deprecated in
/Users/uberbrady/Documents/grokability/snipe-it/vendor/adldap2/adldap2/src/=
Configuration/DomainConfiguration.php
on line 153
 626 mb_convert_encoding(): Handling HTML entities via mbstring is
deprecated; use htmlspecialchars, htmlentities, or
mb_encode_numericentity/mb_decode_numericentity instead in
/Users/uberbrady/Documents/grokability/snipe-it/vendor/symfony/var-dumper/D=
umper/HtmlDumper.php
on line 963
  84 preg_match(): Passing null to parameter #2 ($subject) of type
string is deprecated in
/Users/uberbrady/Documents/grokability/snipe-it/vendor/barryvdh/laravel-deb=
ugbar/src/JavascriptRenderer.php
on line 150
   4 str_replace(): Passing null to parameter #3 ($subject) of type
array|string is deprecated in
/Users/uberbrady/Documents/grokability/snipe-it/vendor/laravel/passport/src=
/PassportServiceProvider.php
on line 268
  84 substr(): Passing null to parameter #1 ($string) of type string
is deprecated in
/Users/uberbrady/Documents/grokability/snipe-it/vendor/barryvdh/laravel-deb=
ugbar/src/JavascriptRenderer.php
on line 150