Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116553
MIME-Version: 1.0
References: <CALp5e-8xoj-RTcvmvDZ68c0pgAJBUcKhkLwZxNLspYhY6G6qEw@mail.gmail.com>
 <CAGBsUrcVjNmOJk8DnOmWzfmr5vVgjWbDzj-bYv1QGDXSdJz=Cw@mail.gmail.com>
 <CALp5e-8=sbQo1rCNW_Hf0Tw6v4PtPss7L9GoHq6XTev8Wh97=g@mail.gmail.com>
 <CA+kxMuRdb2DDNteEn1Os7T5dc-5gUCQ=eTB9Bfr7AA5bb4q2jg@mail.gmail.com>
 <CALp5e-92Te1ZmSKXubG45Fw1nznyiN2sN_LmycYZ1Dxb2YFQ4g@mail.gmail.com>
 <CAESVnVqD+9w=_qhh2ADD9WM0YqmGP_X0Qpfd8qZonbP2wZ4G_Q@mail.gmail.com>
 <CALp5e--CbO1O72WPY7Efyjtm1=HAF9TRsq-a34B04Ed6S_R9wg@mail.gmail.com> <CALp5e--qn4bGJJ0KOXM7tCeYOyxvG9OSm6MHx6miKugHjiJPew@mail.gmail.com>
In-Reply-To: <CALp5e--qn4bGJJ0KOXM7tCeYOyxvG9OSm6MHx6miKugHjiJPew@mail.gmail.com>
Date: Wed, 1 Dec 2021 23:16:38 -0600
Message-ID: <CAESVnVpPAfdeyHV8+F5sLK4sXQzM0cYqPv6dLAcM8ov7pTwdYA@mail.gmail.com>
To: Brady Wetherington <bwetherington@grokability.com>
Cc: Dan Ackroyd <Danack@basereality.com>, Kamil Tekiela <tekiela246@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c0fbc605d222e57d"
Subject: Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties
From: pollita@php.net (Sara Golemon)

--000000000000c0fbc605d222e57d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 30, 2021 at 10:18 PM Brady Wetherington <
bwetherington@grokability.com> wrote:

> >>> =E2=80=A6It's been merged to master, so you could stand up a build no=
w and
> point to the many deprecation warnings you're expecting.  I'm not saying
> send PRs to fix them all, just show real impact rather than theoretical
> guessing. =E2=80=A6
> Okay - good news/bad news/good news -
>
> Bad News: That's because later versions of Laravel dump all
> deprecation warnings straight to /dev/null by default. If you
> configure a log 'channel' for 'deprecations', *then* you get actual
> results. One page load (our dashboard page) generated 267KB of
> deprecation warnings. Clicking through most of the main pages of our
> app generated around 3.5MB of them. And these aren't full
> stack-traces, they're just messages like:
>
> "[2021-12-01 03:48:23] local.WARNING: Creation of dynamic property
> Illuminate\Database\MySqlConnection::$readWriteType is deprecated in
>
> /Users/uberbrady/Documents/grokability/snipe-it/vendor/laravel/framework/=
src/Illuminate/Database/Connection.php
> on line 1368"
>
> Good News: *Many many many* of those deprecation warnings were repeats
> of the same deprecated thing from the exact same place. And *very very
> few* were from the dynamic properties thing. *None* of the dynamic
> properties deprecations were from our code. Everything was from
> composer dependencies, and only a small handful - so, probably pretty
> easy to remediate when it comes to that.
>
>
Does it look like there's any sensitive information in these log entries?
You mentioned they were only in external dependencies so I'm
thinking/hoping not.  What I'm getting at is: Would you mind sharing those
raw logs somewhere. I'm sure someone will find it a fun opportunity to make
some pull requests in a variety of projects.

-Sara

--000000000000c0fbc605d222e57d--