Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116545
MIME-Version: 1.0
References: <CALp5e-8xoj-RTcvmvDZ68c0pgAJBUcKhkLwZxNLspYhY6G6qEw@mail.gmail.com>
 <CAGBsUrcVjNmOJk8DnOmWzfmr5vVgjWbDzj-bYv1QGDXSdJz=Cw@mail.gmail.com>
 <CALp5e-8=sbQo1rCNW_Hf0Tw6v4PtPss7L9GoHq6XTev8Wh97=g@mail.gmail.com>
 <CA+kxMuRdb2DDNteEn1Os7T5dc-5gUCQ=eTB9Bfr7AA5bb4q2jg@mail.gmail.com>
 <CALp5e-92Te1ZmSKXubG45Fw1nznyiN2sN_LmycYZ1Dxb2YFQ4g@mail.gmail.com>
 <CAESVnVqD+9w=_qhh2ADD9WM0YqmGP_X0Qpfd8qZonbP2wZ4G_Q@mail.gmail.com> <CALp5e--CbO1O72WPY7Efyjtm1=HAF9TRsq-a34B04Ed6S_R9wg@mail.gmail.com>
In-Reply-To: <CALp5e--CbO1O72WPY7Efyjtm1=HAF9TRsq-a34B04Ed6S_R9wg@mail.gmail.com>
Reply-To: Brady Wetherington <bwetherington@grokability.com>
Date: Tue, 30 Nov 2021 20:17:59 -0800
Message-ID: <CALp5e--qn4bGJJ0KOXM7tCeYOyxvG9OSm6MHx6miKugHjiJPew@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: Dan Ackroyd <Danack@basereality.com>, Kamil Tekiela <tekiela246@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties
From: internals@lists.php.net ("Brady Wetherington via internals")

>>> =E2=80=A6It's been merged to master, so you could stand up a build now =
and point to the many deprecation warnings you're expecting.  I'm not sayin=
g send PRs to fix them all, just show real impact rather than theoretical g=
uessing. =E2=80=A6
>
>
> That=E2=80=99s a totally fair ask, and I=E2=80=99ll try and get that done=
 and report back. I think I=E2=80=99m probably going to run into some Larav=
el problems here, as they only _just_ came up with a version that will run =
under php 8.1. I=E2=80=99ll get as far as I can and let you know - even if =
I determine that my suspicions were completely incorrect :)

Okay - good news/bad news/good news -

Good News: I managed to snag an 8.2 build and ran Snipe-IT on it, and
it worked completely fine. I cheated a little bit - I didn't try to
make a composer.json that would support 7.4 through 8.2, I just did a
'composer install' from PHPv8, and then switched PHP versions out from
under it. Literally nothing broke at all - I was completely shocked! I
was so worried that I wasn't testing it right that I had to make a
quick little test script with dynamic properties in order to force the
deprecation warning to show up - and it did, so I *do* have the
latest.

Bad News: That's because later versions of Laravel dump all
deprecation warnings straight to /dev/null by default. If you
configure a log 'channel' for 'deprecations', *then* you get actual
results. One page load (our dashboard page) generated 267KB of
deprecation warnings. Clicking through most of the main pages of our
app generated around 3.5MB of them. And these aren't full
stack-traces, they're just messages like:

"[2021-12-01 03:48:23] local.WARNING: Creation of dynamic property
Illuminate\Database\MySqlConnection::$readWriteType is deprecated in
/Users/uberbrady/Documents/grokability/snipe-it/vendor/laravel/framework/sr=
c/Illuminate/Database/Connection.php
on line 1368"

Good News: *Many many many* of those deprecation warnings were repeats
of the same deprecated thing from the exact same place. And *very very
few* were from the dynamic properties thing. *None* of the dynamic
properties deprecations were from our code. Everything was from
composer dependencies, and only a small handful - so, probably pretty
easy to remediate when it comes to that.

So the _other_ deprecation notices are a whole other thing, and having
so many is definitely a drag, but that's a completely separate issue
from this dynamic properties thing, which doesn't seem too bad so far,
for us at least. Other folks might not get off so easily, and
/dev/null-ing deprecation warnings seems like it's kicking the can
down the road, but, well, *we're* OK for 8.2.

I should note that a lot of my PHP-based CLI tools are spewing
deprecations everywhere as well, but they at least still work so I can
perhaps live with that.

-B.