Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:116485 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 40997 invoked from network); 23 Nov 2021 00:42:05 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 23 Nov 2021 00:42:05 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 4510A180510 for ; Mon, 22 Nov 2021 17:38:38 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_05,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 22 Nov 2021 17:38:37 -0800 (PST) Received: by mail-lj1-f170.google.com with SMTP id z8so7707509ljz.9 for ; Mon, 22 Nov 2021 17:38:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=craigfrancis.co.uk; s=default; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T6OTqiNEYndHYrV9gopTFFuW3aB+GTZMEWfsfMFBhZ4=; b=ZsnHrI41kZ/UWdQm+xa5ZWfp4m6eIQLDQvKkN1GfSvSTow1P+llaTxTTl326evH/Ko V3BdJh5G9SUdrkubIOIiNIc8wiMfe4+m7tOw+HFa9hl8Fnu1Xzl0orXyJC2GNV9oii4g Ya+5ItEttVyZ4tgQ3qCbMgdOG9onrAKcUfTWM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T6OTqiNEYndHYrV9gopTFFuW3aB+GTZMEWfsfMFBhZ4=; b=CaQvKTLoYwJQx16mjRfRxu1cWJnaqyfR+//n3WDPC74M0xW8/UPuUd+Z+ZFE3sCsDZ JyqWHdV1ibLBj3oBAvEt4djnXMy3qXs7zYUTi8hUM0w8IU0UCC71IN/ofIdEqFhNkBp7 dlW5DPsr6nzNdQaOl8cjq9MuU/bmepUf+VWc5Rgnul3FO02TP+jNQQyiNEVA6PluqF4m UP2/EmR5UmxoS73B+pyAT+koKjvnzN0wS9jPupBq3NrtApV+Bn4UzaTRxyJuoNG2efeP OHiQBnVWVq107YHCeUPfnum2fpAtXIB/pZBcWZsI2NcUTDYkPUUWFuQbptqHCGtkbD+L XMog== X-Gm-Message-State: AOAM531NmevnQ1A2oArd+/H3lSfnKDP6Wi8Boe1PDoptjBCcNfgiQYAG B2+pYiRYB94jzz3QJ0V9MELS/mNuoLM7W7kwKZGfTg== X-Google-Smtp-Source: ABdhPJzx0+x7oRZ2Cz7642N8uSdidxT/kwZH9BqbzJsGAEzg7EEJjLwFbC9dpCowgz3jNTqnYGNjVmnJTkozfb5xaWA= X-Received: by 2002:a05:651c:210:: with SMTP id y16mr943816ljn.97.1637631515997; Mon, 22 Nov 2021 17:38:35 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Tue, 23 Nov 2021 01:38:25 +0000 Message-ID: To: Sara Golemon Cc: PHP internals Content-Type: multipart/alternative; boundary="000000000000c8dd7905d16accf3" Subject: Re: [PHP-DEV] [VOTE] Deprecate dynamic properties From: craig@craigfrancis.co.uk (Craig Francis) --000000000000c8dd7905d16accf3 Content-Type: text/plain; charset="UTF-8" On Tue, 16 Nov 2021 at 22:21, Sara Golemon wrote: > 1. Do you have code you're responsible for which uses dynamic properties so > broadly that adding this attribute is a burden? > 2. Do you know of real code in widespread use which uses dynamic properties > so broadly that adding this attribute is a burden? > > All I see being bandied about are hypotheticals. That's fair, and tbh mine has been the hypothetical legacy code... reading all the discussion, I think I've been convinced it's worth the change, especially as this is a deprecation a few versions before anything actually breaks. I think my original negative opinion was more of a "oh, not more stuff to change", especially while I know of a few people now fixing all of the issues that "passing null to non-nullable arguments of internal functions" is causing; with trim, strlen, strpos, etc... https://externals.io/message/116076 And even more off-topic... well done everyone for on PHP Foundation, and thank you Nikita for everything you have done (you really have accomplished a lot). Craig --000000000000c8dd7905d16accf3--