Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116482
Content-Type: multipart/alternative;
 boundary="------------aRkXmciMARqHR0ky3nJKKtc0"
Message-ID: <5dda3cf0-2611-e7aa-43a0-7fcd971606d3@gmx.de>
Date: Mon, 22 Nov 2021 23:04:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.0
Content-Language: de-DE
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: internals@lists.php.net
References: <99cc5fab-42ff-f865-cdfc-8942557c86b8@gmx.de>
 <CAF+90c_4hNKU2-srqNE3JXePkEUsho=s_hVq3qeAOQNPcepRfg@mail.gmail.com>
In-Reply-To: <CAF+90c_4hNKU2-srqNE3JXePkEUsho=s_hVq3qeAOQNPcepRfg@mail.gmail.com>
Subject: Re: [PHP-DEV] PHP 8.2 proposal: "match", allow "default" as
 conditional_expression, e.g. 'en_US', 'en_GB', default => loadDefaults()
From: syntheme@gmx.de (Andreas)

--------------aRkXmciMARqHR0ky3nJKKtc0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 22.11.21 22:06, Nikita Popov wrote:
> On Mon, Nov 22, 2021 at 7:18 PM Andreas <syntheme@gmx.de> wrote:
>
>     Hi internals,
>
>     This is a proposal to allow to append the `default` pattern by
>     comma to
>     the end of the last match branch. (Like a conditional_expression)
>
>     This allows to re-use the return_expression if required and avoids
>     code
>     duplication.
>
>     PROPOSAL: PHP 8.2
>
>     <?php
>     return match ($locale) {
>     =C2=A0=C2=A0=C2=A0=C2=A0 'de_DE', 'de_CH', 'de_AT' =3D> loadGermanLa=
nguageSettings(),
>     =C2=A0=C2=A0=C2=A0=C2=A0 'en_US', 'en_GB', default =3D> loadDefaultL=
anguageSettings(),
>     };
>     ?>
>
>
> Isn't this equivalent to just this?
>
> <?php
> return match ($locale) {
> =C2=A0=C2=A0=C2=A0=C2=A0 'de_DE', 'de_CH', 'de_AT' =3D> loadGermanLangua=
geSettings(),
> =C2=A0=C2=A0=C2=A0=C2=A0 default =3D> loadDefaultLanguageSettings(),
> };
>
> 'en_US' and 'en_GB' will already go to the default branch if they're
> not listed explicitly.
>
> Regards,
> Nikita

Hi Nikita,

nice to meet you. Yes, that's indeed possible.

But I personally like to list all handled conditional_expressions (here
the $locales) in the match
in order to directly see in the code for later reference, which of them
are explicit handled (and which are handled by the default pattern).

This proposal is mainly syntactic sugar to avoid code duplication, in
this case the duplicate return_expression loadDefaultLanguageSettings().

Just as a side note: PHPStorm's inspection suggests "Merge with default
arm" every time because of this code duplication.

Regards,
Andreas


--------------aRkXmciMARqHR0ky3nJKKtc0--