Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116469
Date: Sun, 21 Nov 2021 17:31:44 +0100
Reply-To: Luca Petrucci <luca@lucapetrucci.net>
To: internals@lists.php.net
Message-ID: <20211121163144.ipyopbywu53uhwwq@lucapetrucci.net>
References: <20211118074647.muibn4mgfezzy75b@lucapetrucci.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211118074647.muibn4mgfezzy75b@lucapetrucci.net>
Subject: Re: Proposal: &$result_code=null parameter in shell_exec()
From: internals@lists.php.net ("Luca Petrucci via internals")

On Thu, Nov 18, 2021 at 08:46:47AM +0100, Luca Petrucci via internals wrote:
> Hi internals,
> 
> This is a proposal to add an optional parameter &$result_code = null to the shell_exec() function.
> 
> For clarity, the current signature is
> shell_exec(string $command): string|false|null
> The proposed signature is
> shell_exec(string $command, int &$result_code = null): string|false|null
> 
> If present, the result_code parameter is set to the exit code of the command, as it is in exec() and system().
> 
> This feature request was also posted by another user on https://bugs.php.net/bug.php?id=81493
> I have a draft pull request at https://github.com/php/php-src/pull/7663
> 
> Thoughts?
> 
> Thanks,
> Luca

Hi internals,

Having seen the initial comments about this proposal, I'd like to
request karma to create the RFC (username: lpt).

Thanks,
Luca