Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116442
MIME-Version: 1.0
References: <20211118074647.muibn4mgfezzy75b@lucapetrucci.net>
In-Reply-To: <20211118074647.muibn4mgfezzy75b@lucapetrucci.net>
Date: Thu, 18 Nov 2021 10:29:05 +0100
Message-ID: <CAF+90c8A7P-6D6s6p9FpsOofo4EgAU8iYFbHWwc519GPWgCEDg@mail.gmail.com>
To: Luca Petrucci <luca@lucapetrucci.net>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000002e161d05d10ccb0e"
Subject: Re: [PHP-DEV] Proposal: &$result_code=null parameter in shell_exec()
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000002e161d05d10ccb0e
Content-Type: text/plain; charset="UTF-8"

On Thu, Nov 18, 2021 at 8:47 AM Luca Petrucci via internals <
internals@lists.php.net> wrote:

> Hi internals,
>
> This is a proposal to add an optional parameter &$result_code = null to
> the shell_exec() function.
>
> For clarity, the current signature is
> shell_exec(string $command): string|false|null
> The proposed signature is
> shell_exec(string $command, int &$result_code = null): string|false|null
>
> If present, the result_code parameter is set to the exit code of the
> command, as it is in exec() and system().
>
> This feature request was also posted by another user on
> https://bugs.php.net/bug.php?id=81493
> I have a draft pull request at https://github.com/php/php-src/pull/7663
>
> Thoughts?
>
> Thanks,
> Luca
>

This looks like a reasonable addition to me. Between shell_exec(),
system(), passthru() and exec(), shell_exec() is the only function that
doesn't currently accept a $result_code parameter, so including it makes
sense for consistency.

Regards,
Nikita

--0000000000002e161d05d10ccb0e--