Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116414
MIME-Version: 1.0
References: <CAF+90c9_qu=PiTS81J2mesPfJdz7n5nSi3qoLNLjhEGN-aTytA@mail.gmail.com>
 <CAF+90c9XwAwbA60NQgnu5btiuE_Y9n8eASnVi8TH65jK3A2C8w@mail.gmail.com>
 <alpine.DEB.2.23.453.2111150948120.4221@singlemalt.home.derickrethans.nl>
 <371ca983-2b07-ae39-3629-49cf7ff8ee64@heigl.org> <CAF+90c-om9Qq7YAaf_GdRxKn5e-=8WRVDvy1gC=pA2C8dH=Wqg@mail.gmail.com>
 <497ab532-a39d-389c-8bca-86768650c2f4@heigl.org> <ae25a625-20ca-bc9a-d1ee-0f7ac4eba7c7@gmail.com>
 <a66fa304-1025-6953-0c3f-ca1dcbca81df@heigl.org> <d7f1982b-4253-c370-2d83-f5301b0f39e8@gmail.com>
 <a3a71094-c0f9-5d79-3cdc-089b7a6b1093@heigl.org> <bd3c2076-c7f1-eba0-e77e-334d13430416@gmail.com>
In-Reply-To: <bd3c2076-c7f1-eba0-e77e-334d13430416@gmail.com>
Date: Tue, 16 Nov 2021 08:59:34 -0600
Message-ID: <CAO3MkaD4+kY+M4qA-36mzHx1rX6yamtzHEEu9g8A-uEmJkTHmA@mail.gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000013849505d0e92d9d"
Subject: Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties
From: neclimdul@gmail.com (James Gilliland)

--00000000000013849505d0e92d9d
Content-Type: text/plain; charset="UTF-8"

On Tue, Nov 16, 2021 at 4:23 AM Rowan Tommins <rowan.collins@gmail.com>
wrote:

> On 16/11/2021 09:27, Andreas Heigl wrote:
> >
> >> I see, yes, code that is 100% perfectly tested can get away without
> >> the language performing any error checking at all - the behaviour is
> >> all guaranteed by the tests. I would be very surprised if even 1% of
> >> PHP applications can claim such comprehensive tests.
> >
> > The topic here was that new code can verify the declaration of a
> > property by using tests. That does not need to happen on the language
> > level. I was never talking about adding tests for existing code.
>
>
>
> For most code bases, even new ones being written from scratch in PHP
> 8.0, that level of testing simply doesn't exist, and having the language
> tell you "hey, you wrote $this->loger instead of $this->logger" is a
> useful feature. And, in a lot of cases, more useful than having the
> language say "OK, I've created your dynamic $loger property for you",
> which is what currently happens.
>

What you described there sounds like a warning and not a fatal error. Maybe
that's where some of the trepidation is coming from. I know I'm less
worried about the deprecation notice and more worried about what happens in
PHP 9 when it's a fatal error.

--00000000000013849505d0e92d9d--