Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116373
MIME-Version: 1.0
References: <CAF+90c9_qu=PiTS81J2mesPfJdz7n5nSi3qoLNLjhEGN-aTytA@mail.gmail.com>
 <CAF+90c9XwAwbA60NQgnu5btiuE_Y9n8eASnVi8TH65jK3A2C8w@mail.gmail.com>
 <alpine.DEB.2.23.453.2111150948120.4221@singlemalt.home.derickrethans.nl> <371ca983-2b07-ae39-3629-49cf7ff8ee64@heigl.org>
In-Reply-To: <371ca983-2b07-ae39-3629-49cf7ff8ee64@heigl.org>
Date: Mon, 15 Nov 2021 15:53:40 +0200
Message-ID: <CAAwdEzC6hCWB-_AZQDRirZCT38fvmkjxJ=w6vDpcpCSY8j59_A@mail.gmail.com>
To: Andreas Heigl <andreas@heigl.org>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ea363b05d0d423d3"
Subject: Re: [PHP-DEV] Re: [RFC] Deprecate dynamic properties
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--000000000000ea363b05d0d423d3
Content-Type: text/plain; charset="UTF-8"

On Mon, Nov 15, 2021 at 2:52 PM Andreas Heigl <andreas@heigl.org> wrote:

>
> And as far as I can see from the PR associated with this RFC it will not
> make life easier for the internals team. It is not like there will be
> hundreds of lines code less to maintain. On the contrary. There is more
> code and more logic to maintain [2].
>

Sometimes it  needs to be worse until it's better.
Some points that evolved during discussion also mentioned the intention of
how easy to allow it to be to opt-in and in the end the attribute was
chosen as the easiest one.
Even if the intention was to simplify the code to maintain, it was not
clear how much PHP users would want to stay without this feature.
And the problem was that using the attribute, it would not be easy to
remove it in PHP 9.
But at least it would give a better sense of usage once we get to PHP 9 so
it can be completely removed only in PHP 10+ or to use a more strict
opt-in mechanism.

So yes, you are right, having it like this would make the code a bit worse
to maintain for 8 years and easier to maintain after that, if I got it
right.

But the benefit related to the dynamic properties bugs reduction would be
seen in userland starting with PHP 8.2.

Regards,
Alex

--000000000000ea363b05d0d423d3--