Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116345
MIME-Version: 1.0
References: <CAF+90c_wDsjuMFAoQLehkn5GeoLv5GByczF+o-eDmYe+VVRxTA@mail.gmail.com>
 <DC6B97F4-C8F4-463D-9F33-74227AE5EC74@php.net> <0A40B090-43E3-484F-B67F-175C3B8F7CD6@php.net>
 <CAF+90c-igAJ0ZFbvbuKtZyxN99y-kDr_VVm9FDcGorLcb3xWyQ@mail.gmail.com>
In-Reply-To: <CAF+90c-igAJ0ZFbvbuKtZyxN99y-kDr_VVm9FDcGorLcb3xWyQ@mail.gmail.com>
Date: Sun, 14 Nov 2021 18:48:02 +0700
Message-ID: <CAEZPtU4fwJbYr4zc4BEGQAL8kbtUKbbex3tG2zrG1=DoxXn5RA@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Ben Ramsey <ramsey@php.net>, php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000000f973205d0be46c7"
Subject: Re: [PHP-DEV] [VOTE] Deprecate dynamic properties
From: pierre.php@gmail.com (Pierre Joye)

--0000000000000f973205d0be46c7
Content-Type: text/plain; charset="UTF-8"

Hi Nikita,

On Fri, Nov 12, 2021, 11:34 PM Nikita Popov <nikita.ppv@gmail.com> wrote:

FWIW I think we should always deprecate things as soon as possible, to give
> people the maximum amount of awareness and time to address the issue before
> the actual removal occurs.


I voted no however I agree on this part, with a slight different view on
how it may be done.

> Meanwhile, 8.2 should include the
> > AllowDynamicProperties attribute so folks can start preparing.
> >
>
> Given how attributes in PHP work, this doesn't make sense to me. You can
> already use #[AllowDynamicProperties] in your code right now, without any
> special support from PHP. Only static analyzers / IDEs need to know that
> they shouldn't complain about it even on versions where it does not
> technically exist.



I agree with other that it should be allowed by default.

Also I do see it as a kind of strict mode addition and the depreciation as
well could be strict mode only.

It could make things too complicated, so only off by default would be an
acceptable compromise to me.

best
Pierre

--0000000000000f973205d0be46c7--