Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116338
MIME-Version: 1.0
References: <CAF+90c_wDsjuMFAoQLehkn5GeoLv5GByczF+o-eDmYe+VVRxTA@mail.gmail.com>
 <CAJp_myU5Wc3heD0vB7P8a65x4zd2pBmh9jt8Jb38SP80Kz0JSQ@mail.gmail.com>
 <f6c83821-e3f1-422b-914b-a26c7c64b934@www.fastmail.com> <CAJp_myVPsGY023o6+qMYu95M8fBdtGMzyh7xf_NJZhisKZc7bA@mail.gmail.com>
 <6e2d3e92-b53a-8264-85c6-d2d0062ee449@gmx.de>
In-Reply-To: <6e2d3e92-b53a-8264-85c6-d2d0062ee449@gmx.de>
Date: Sat, 13 Nov 2021 08:26:31 +0000
Message-ID: <CAJvSBVNgKNC09SkdNcDDS7S=_uiBS6QTHNozz25Sfi2eKYF9mQ@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: "Matthew Weier O'Phinney" <mweierophinney@gmail.com>, Larry Garfield <larry@garfieldtech.com>, 
	php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c64aaf05d0a75589"
Subject: Re: [PHP-DEV] [VOTE] Deprecate dynamic properties
From: phpmailinglists@gmail.com (Peter Bowyer)

--000000000000c64aaf05d0a75589
Content-Type: text/plain; charset="UTF-8"

On Sat, 13 Nov 2021, 00:14 Christoph M. Becker, <cmbecker69@gmx.de> wrote:

> Offering an
> opt-out of dynamic properties or some switch to disable the deprecation
> would not help in that regard.
>

Given this is a big change to the way PHP has behaved for decades I did
wonder why the RFC didn't propose an opt-out of dynamic properties rather
than opt-in, preserving the long-term language behaviour. So thanks for
covering that.

I think you and the PHP internals community will be surprised by how widely
used dynamic properties are. I read through a handful of WordPress plugins
we have installed and found a few. And in my own where I'm using a named
class instead of an array.

I work with modern framework based code most of the time and I find it easy
to forget what is out there as quintessential or traditional PHP code.

Whether we have #[AllowDynamicProperties] or #[DenyDynamicProperties] one
set of PHP users is going to be doing a find & replace across their
codebase.

From a DX perspective I'd rather have #[DenyDynamicProperties] as it's like
declaring strict_mode and opt-in.

Either way are the planned engine changes feasible, as the feature of
dynamic properties stays in the language but toggled off/on per class?

Peter

>

--000000000000c64aaf05d0a75589--