Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116256
MIME-Version: 1.0
References: <5872e8bb-d944-2fae-938f-ae1948b2660b@gmail.com>
 <CAOwTYAvNt+AtgG3oy+VA2nnGc7g0d1+zjurpmRCfJ5nJXyepVA@mail.gmail.com>
 <CAOwTYAs3YaOS8H1Jp0srRObDCyruxjPztD3DMmKb_mFr+dkYVg@mail.gmail.com>
 <b98bef5e-bd2a-c82b-f61c-c895f5ea1487@gmail.com> <CAJmy8YG=fY5F1RZs87CtriuKkBWypruiFVET5R0aCAeG8MW8jw@mail.gmail.com>
 <18cf67d6-dca7-22e0-3a9a-8fc5f1b36539@heigl.org> <CAJmy8YECnphg=Uyc-gbu9+MPuSFPswajExbNenCmGmyaNqnvWQ@mail.gmail.com>
 <CAJmy8YH=hbpHMmABtovSC4d-ADoHyVjDJs7r+FqtiERLfDZ-8w@mail.gmail.com>
 <CANLbj-rvEbn1Hb9ZiTBuEEcA82D+oDXjkCLNGHq+sgEh5pDfPw@mail.gmail.com>
 <CAJmy8YFL_OsYAp0utRTr0F0W_Gx5hgyCmdjdJna7LGDPuoKVyg@mail.gmail.com> <CAJmy8YHrY-W88AMiCWmtPOhRpEc=tar_Or+TKB9Mrv56AC3uKg@mail.gmail.com>
In-Reply-To: <CAJmy8YHrY-W88AMiCWmtPOhRpEc=tar_Or+TKB9Mrv56AC3uKg@mail.gmail.com>
Date: Sun, 10 Oct 2021 16:40:18 +0530
Message-ID: <CANLbj-rZOusixe7QiY0OyQYPVxHGKu368DV4DRzpVyR368=6Rw@mail.gmail.com>
To: Hans Henrik Bergan <divinity76@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Unbreak git.php.net links?
From: ayesh@php.watch (Ayesh Karunaratne)

>
> Soooo, what's next?
>
> On Tue, 5 Oct 2021 at 18:06, Hans Henrik Bergan <divinity76@gmail.com>
> wrote:
>
> > @Ayesh thanks, added support for those url (
> > https://github.com/divinity76/git-php-net-redirector/commit/072a579d140=
a7481e76e95bd8c2d120ee2f71565
> > ), also it looks like version numbers got mixed up in your example #2 ,
> > "8.0.0RC2" vs "8.1.0RC3", that is surely a typo?
> >
> > >It is the name of the git repository on git.php.net. There were
> > several other repos for PECL, bug tracker, docs in multiple languages,
> > etc. I have added support for a static list that maps git.php.net
> > names to GitHub repo under `php` organization namespace.
> >
> > oh i see.
> >
> > fwiw, your implementation looks more professional / enterprise-y :)
> >
> >
> > On Tue, 5 Oct 2021 at 15:43, Ayesh Karunaratne <ayesh@php.watch> wrote:
> >
> >> > here is an initial implementation:
> >> >
> >> https://github.com/divinity76/git-php-net-redirector/blob/main/src/red=
irector.php
> >> > it is just a minimum-effort implementation, anyone feel free to make
> >> > something better (also i have no idea how the "p" argument is suppos=
ed
> >> to
> >> > be parsed, so i just guessed)
> >> >
> >> > it passes "Stanislav Malyshev"'s initial sample url, but it probably
> >> fails
> >> > on any other formats, if anyone has test urls, share em
> >> >
> >> >
> >> >
> >> > On Mon, 4 Oct 2021 at 08:38, Hans Henrik Bergan <divinity76@gmail.co=
m>
> >> > wrote:
> >> >
> >> > > >So who's going to work on it? Doesn't make sense to have 5 people
> >> work
> >> > > > on it independently from each other ;-)
> >> > >
> >> > > if nobody else wants to do it, i can make an initial implementatio=
n on
> >> > > october 9th (6 days from now),
> >> > >
> >> > > but wouldn't surprise me at all if someone else wants to do it ^^
> >> > >
> >> > >
> >> > > On Mon, 4 Oct 2021 at 08:01, Andreas Heigl <andreas@heigl.org> wro=
te:
> >> > >
> >> > >> Hey all.
> >> > >>
> >> > >> On 04.10.21 07:52, Hans Henrik Bergan wrote:
> >> > >> > there's also plenty of broken links on reddit to git.php.net , =
ref
> >> > >> > https://www.google.com/search?q=3Dgit.php.net+site%3Areddit.com
> >> > >> >
> >> > >> > it wouldn't be hard to set up a redirector parsing commit ids o=
ut
> >> of the
> >> > >> > url and redirecting to github,
> >> > >> > +1 from me.
> >> > >>
> >> > >> So who's going to work on it? Doesn't make sense to have 5 people
> >> work
> >> > >> on it independently from each other ;-)
> >> > >>
> >> > >> Cheers
> >> > >>
> >> > >> Andreas
> >> > >> --
> >> > >>                                                                ,,=
,
> >> > >>                                                               (o =
o)
> >> > >>
> >> +---------------------------------------------------------ooO-(_)-Ooo-=
+
> >> > >> | Andreas Heigl
> >>  |
> >> > >> | mailto:andreas@heigl.org                  N 50=C2=B022'59.5" E
> >> 08=C2=B023'58" |
> >> > >> | https://andreas.heigl.org
> >>    |
> >> > >>
> >> +---------------------------------------------------------------------=
+
> >> > >> | https://hei.gl/appointmentwithandreas
> >>    |
> >> > >>
> >> +---------------------------------------------------------------------=
+
> >> > >>
> >> > >
> >>
> >>
> >> Hi Stanislav/Hans,
> >> Thanks for opening this conversation and the initial implementation.
> >>
> >> Having worked with a few cgit repositories before, I happen to recall
> >> some of the other URL patterns. I worked on a similar implementation
> >> to Hans's at https://github.com/Ayesh/git-php-redirect
> >>
> >> > something better (also i have no idea how the "p" argument is suppos=
ed
> >> to
> >> > be parsed, so i just guessed)
> >>
> >> It is the name of the git repository on git.php.net. There were
> >> several other repos for PECL, bug tracker, docs in multiple languages,
> >> etc. I have added support for a static list that maps git.php.net
> >> names to GitHub repo under `php` organization namespace.
> >>
> >> In addition to the URL patterns Hans have covered
> >> (p=3Dphp-src;h=3DHEX{40}), I thought to add a few more patterns:
> >>
> >> - FROM: http://git.php.net/?p=3Dphp-src.git;a=3Dcommit;h=3D5af586be (
> >> `/[a-z0-9]{7,}$/` )
> >>   TO:       https://github.com/php/php-src/commit/5af586be
> >>
> >> - FROM:
> >> https://git.php.net/?p=3Dphp-src.git;a=3Dshortlog;h=3Drefs/tags/php-8.=
0.0RC2
> >>   TO:       https://github.com/php/php-src/releases/tag/php-8.1.0RC3
> >>
> >> - FROM:
> >> https://git.php.net/?p=3Dphp-src.git;a=3D{tree,log,shortlog};h=3Drefs/=
heads/master;hb=3Drefs/heads/master
> >>   TO:       https://github.com/php/php-src/{tree,commits,commits}/mast=
er
> >>
> >> - FROM: http://git.php.net/?p=3Dphp-src.git;a=3Dlog
> >>   TO:       https://github.com/php/php-src
> >>
> >> Cheers,
> >> Ayesh.
> >>
> >

From what I could observe:
 - DNS for git.php.net still resolves to 208.43.231.11 IP address.
 - Server at 208.43.231.11 does not listen/accept HTTP(S) traffic.
 - git.php.net was previously served with *.php.net TLS certificate.

I suppose the next steps would be to:

1. Check if the DNS is correctly configured, and make sure
208.43.231.11 is indeed an IP address that we could use.
2. Setup vhosts and TLS for git.php.net.
3. Setup the redirection script.

@Hans Henrik Bergan opened PR at
https://github.com/Ayesh/git-php-redirect with test cases, and I think
his approach at a simple redirect script works and supports the same
patterns too.

That said, it wouldn't be terribly inconvenient to redirect all
traffic using the Nginx/Apache rewrite rules either. We wouldn't even
need to have a PHP-FPM or alike running that server.

Cheers,
Ayesh.