Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116254
MIME-Version: 1.0
References: <5872e8bb-d944-2fae-938f-ae1948b2660b@gmail.com>
 <CAOwTYAvNt+AtgG3oy+VA2nnGc7g0d1+zjurpmRCfJ5nJXyepVA@mail.gmail.com>
 <CAOwTYAs3YaOS8H1Jp0srRObDCyruxjPztD3DMmKb_mFr+dkYVg@mail.gmail.com>
 <b98bef5e-bd2a-c82b-f61c-c895f5ea1487@gmail.com> <CAJmy8YG=fY5F1RZs87CtriuKkBWypruiFVET5R0aCAeG8MW8jw@mail.gmail.com>
 <18cf67d6-dca7-22e0-3a9a-8fc5f1b36539@heigl.org> <CAJmy8YECnphg=Uyc-gbu9+MPuSFPswajExbNenCmGmyaNqnvWQ@mail.gmail.com>
 <CAJmy8YH=hbpHMmABtovSC4d-ADoHyVjDJs7r+FqtiERLfDZ-8w@mail.gmail.com>
 <CANLbj-rvEbn1Hb9ZiTBuEEcA82D+oDXjkCLNGHq+sgEh5pDfPw@mail.gmail.com> <CAJmy8YFL_OsYAp0utRTr0F0W_Gx5hgyCmdjdJna7LGDPuoKVyg@mail.gmail.com>
In-Reply-To: <CAJmy8YFL_OsYAp0utRTr0F0W_Gx5hgyCmdjdJna7LGDPuoKVyg@mail.gmail.com>
Date: Fri, 8 Oct 2021 16:43:19 +0200
Message-ID: <CAJmy8YHrY-W88AMiCWmtPOhRpEc=tar_Or+TKB9Mrv56AC3uKg@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009a329a05cdd868f6"
Subject: Re: [PHP-DEV] Unbreak git.php.net links?
From: divinity76@gmail.com (Hans Henrik Bergan)

--0000000000009a329a05cdd868f6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Soooo, what's next?

On Tue, 5 Oct 2021 at 18:06, Hans Henrik Bergan <divinity76@gmail.com>
wrote:

> @Ayesh thanks, added support for those url (
> https://github.com/divinity76/git-php-net-redirector/commit/072a579d140a7=
481e76e95bd8c2d120ee2f71565
> ), also it looks like version numbers got mixed up in your example #2 ,
> "8.0.0RC2" vs "8.1.0RC3", that is surely a typo?
>
> >It is the name of the git repository on git.php.net. There were
> several other repos for PECL, bug tracker, docs in multiple languages,
> etc. I have added support for a static list that maps git.php.net
> names to GitHub repo under `php` organization namespace.
>
> oh i see.
>
> fwiw, your implementation looks more professional / enterprise-y :)
>
>
> On Tue, 5 Oct 2021 at 15:43, Ayesh Karunaratne <ayesh@php.watch> wrote:
>
>> > here is an initial implementation:
>> >
>> https://github.com/divinity76/git-php-net-redirector/blob/main/src/redir=
ector.php
>> > it is just a minimum-effort implementation, anyone feel free to make
>> > something better (also i have no idea how the "p" argument is supposed
>> to
>> > be parsed, so i just guessed)
>> >
>> > it passes "Stanislav Malyshev"'s initial sample url, but it probably
>> fails
>> > on any other formats, if anyone has test urls, share em
>> >
>> >
>> >
>> > On Mon, 4 Oct 2021 at 08:38, Hans Henrik Bergan <divinity76@gmail.com>
>> > wrote:
>> >
>> > > >So who's going to work on it? Doesn't make sense to have 5 people
>> work
>> > > > on it independently from each other ;-)
>> > >
>> > > if nobody else wants to do it, i can make an initial implementation =
on
>> > > october 9th (6 days from now),
>> > >
>> > > but wouldn't surprise me at all if someone else wants to do it ^^
>> > >
>> > >
>> > > On Mon, 4 Oct 2021 at 08:01, Andreas Heigl <andreas@heigl.org> wrote=
:
>> > >
>> > >> Hey all.
>> > >>
>> > >> On 04.10.21 07:52, Hans Henrik Bergan wrote:
>> > >> > there's also plenty of broken links on reddit to git.php.net , re=
f
>> > >> > https://www.google.com/search?q=3Dgit.php.net+site%3Areddit.com
>> > >> >
>> > >> > it wouldn't be hard to set up a redirector parsing commit ids out
>> of the
>> > >> > url and redirecting to github,
>> > >> > +1 from me.
>> > >>
>> > >> So who's going to work on it? Doesn't make sense to have 5 people
>> work
>> > >> on it independently from each other ;-)
>> > >>
>> > >> Cheers
>> > >>
>> > >> Andreas
>> > >> --
>> > >>                                                                ,,,
>> > >>                                                               (o o)
>> > >>
>> +---------------------------------------------------------ooO-(_)-Ooo-+
>> > >> | Andreas Heigl
>>  |
>> > >> | mailto:andreas@heigl.org                  N 50=C2=B022'59.5" E
>> 08=C2=B023'58" |
>> > >> | https://andreas.heigl.org
>>    |
>> > >>
>> +---------------------------------------------------------------------+
>> > >> | https://hei.gl/appointmentwithandreas
>>    |
>> > >>
>> +---------------------------------------------------------------------+
>> > >>
>> > >
>>
>>
>> Hi Stanislav/Hans,
>> Thanks for opening this conversation and the initial implementation.
>>
>> Having worked with a few cgit repositories before, I happen to recall
>> some of the other URL patterns. I worked on a similar implementation
>> to Hans's at https://github.com/Ayesh/git-php-redirect
>>
>> > something better (also i have no idea how the "p" argument is supposed
>> to
>> > be parsed, so i just guessed)
>>
>> It is the name of the git repository on git.php.net. There were
>> several other repos for PECL, bug tracker, docs in multiple languages,
>> etc. I have added support for a static list that maps git.php.net
>> names to GitHub repo under `php` organization namespace.
>>
>> In addition to the URL patterns Hans have covered
>> (p=3Dphp-src;h=3DHEX{40}), I thought to add a few more patterns:
>>
>> - FROM: http://git.php.net/?p=3Dphp-src.git;a=3Dcommit;h=3D5af586be (
>> `/[a-z0-9]{7,}$/` )
>>   TO:       https://github.com/php/php-src/commit/5af586be
>>
>> - FROM:
>> https://git.php.net/?p=3Dphp-src.git;a=3Dshortlog;h=3Drefs/tags/php-8.0.=
0RC2
>>   TO:       https://github.com/php/php-src/releases/tag/php-8.1.0RC3
>>
>> - FROM:
>> https://git.php.net/?p=3Dphp-src.git;a=3D{tree,log,shortlog};h=3Drefs/he=
ads/master;hb=3Drefs/heads/master
>>   TO:       https://github.com/php/php-src/{tree,commits,commits}/master
>>
>> - FROM: http://git.php.net/?p=3Dphp-src.git;a=3Dlog
>>   TO:       https://github.com/php/php-src
>>
>> Cheers,
>> Ayesh.
>>
>

--0000000000009a329a05cdd868f6--