Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116235
MIME-Version: 1.0
References: <CABTDVhBkTgyXSygiwaUqiHVTL22_-wYFqieLvqMB9v+-X6n_uw@mail.gmail.com>
 <CAF+90c-vTxm912AgTzLnbn5m=+9Fw+o8Bthr3L019Yrc6Xsg=A@mail.gmail.com>
In-Reply-To: <CAF+90c-vTxm912AgTzLnbn5m=+9Fw+o8Bthr3L019Yrc6Xsg=A@mail.gmail.com>
Reply-To: Levi Morrison <levi.morrison@datadoghq.com>
Date: Wed, 6 Oct 2021 06:52:33 -0600
Message-ID: <CAAKU0unSGNy=0j4fogyzOkRqnN7N2X+OA=+sGZU4Ku8kmfS1Xg@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Go Kudo <zeriyoshi@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [Pre-Vote Announcement] Move RNG functions Random Extension
From: internals@lists.php.net ("Levi Morrison via internals")

On Mon, Oct 4, 2021 at 4:21 AM Nikita Popov <nikita.ppv@gmail.com> wrote:
>
> On Wed, Sep 22, 2021 at 1:21 PM Go Kudo <zeriyoshi@gmail.com> wrote:
>>
>> The voting phase for the following RFCs will begin as soon as two weeks
>> have passed.
>>
>> https://externals.io/message/115975
>>
>> I don't see any particular discussion, so I'm contacting you just in case.
>
>
> I'm pretty neutral on this proposal. I don't think there's a strong motivation to move this functionality into a separate extension, but I also don't see any particular problems with doing it (as long as it's an always-required extension, which this is).
>
> I believe Levi is a proponent of splitting up ext/standard into smaller extensions, maybe he has some thoughts on this.
>
> Regards,
> Nikita

I've glanced at the patch; it seems fine. I do like smaller, focused
extensions better than throwing things in `ext/standard`.

Can we change the return types of the functions in this extension
returning `SUCCESS`/`FAILURE` to `zend_result` at the same time? I
think it's just these two:

  - php_random_bytes
  - php_random_int

Actually, is that something we could still do for PHP 8.1?