Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:116229 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 16141 invoked from network); 5 Oct 2021 15:22:14 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 5 Oct 2021 15:22:14 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 296A2180554 for ; Tue, 5 Oct 2021 09:06:44 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 5 Oct 2021 09:06:43 -0700 (PDT) Received: by mail-pg1-f179.google.com with SMTP id r201so14286352pgr.4 for ; Tue, 05 Oct 2021 09:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Medzd56F6AkK/N2udkKSTQQzjYONR5gPb3fbr3fGUCk=; b=FbVLhxct+oefUV1tiLkjVJcxGDphMVjIXrrA0lo9ySU7xhri32p191Tl17RDvMCseJ Q7oJjohicN+PcyKyY1QAFRDIi4cnPz/llrClQKGCOpdeRB+JSkkHdqEiSw+GCjvCN239 EZPeyJvwUHb3ldwODbAyBYF60s++q76jDn76yL+23vyphNTEkn0boIlbTHzx6zOXHRIo 3p8YjEUuY21AwNSlAl+zScEG1PphUsVnqxPJmPv/rdKCoHlXM/VkEMmvWBN/DeNz6j58 1SmpcCUm+7fZi6ADweAiN1T21va0hXFLLIxxXzSDLsa++ELdBvQtbnvlUO7ZlhTkztIT wNVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Medzd56F6AkK/N2udkKSTQQzjYONR5gPb3fbr3fGUCk=; b=YeNg9Aa7FVpbRxl19ewWwyOk+EVXPt3J/O+VGJemCcr+pogY+PGQciPfV+FFhC68G/ Hg7cSySADwpjqTgO3Zb0ArqTPPcjTh7nJu9cPQVZQDZj/tXB1CiyHWQpxNdfm3OgcN4Z HS1iKQa1HANgVZ14+ASA0JlP4R1/bt78ouOlE5dSkTy40C7V1XNpCk3j1p29q/0oohFd ms+PZ2pvcnBhC1m3ddn6xN+lC+G1XPabQ17NWttmHGmrIByvTcYWt4f5yh5qOk27lxJ5 zrrHSLuNtBLFQTFpSVHbj0cm/9AfbTmaY3yXAhIKrSjE0eozrkKqu+eyxDUAesALUOaI cisw== X-Gm-Message-State: AOAM530GE/GL1/r9O8HULvFSTH89TLfC0xvgPAV34dcrkZoowvwI0NEi lqzNaLxndZk4QqhqHqrCtWHZtj9hABJ0/4NZASGVZXjgHNMUZ8fEFn0= X-Google-Smtp-Source: ABdhPJwGPSovIxnMxVwThN20bFovxTSVDJf/CqHiQY5+60sZYY6KNOY3zv3sRia3T7vEtGs6ZRl+mV7ngKRs/S1syTI= X-Received: by 2002:a63:d654:: with SMTP id d20mr704934pgj.122.1633449997039; Tue, 05 Oct 2021 09:06:37 -0700 (PDT) MIME-Version: 1.0 References: <5872e8bb-d944-2fae-938f-ae1948b2660b@gmail.com> <18cf67d6-dca7-22e0-3a9a-8fc5f1b36539@heigl.org> In-Reply-To: Date: Tue, 5 Oct 2021 18:06:00 +0200 Message-ID: To: PHP internals Content-Type: multipart/alternative; boundary="000000000000d502b805cd9d3628" Subject: Re: [PHP-DEV] Unbreak git.php.net links? From: divinity76@gmail.com (Hans Henrik Bergan) --000000000000d502b805cd9d3628 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable @Ayesh thanks, added support for those url ( https://github.com/divinity76/git-php-net-redirector/commit/072a579d140a748= 1e76e95bd8c2d120ee2f71565 ), also it looks like version numbers got mixed up in your example #2 , "8.0.0RC2" vs "8.1.0RC3", that is surely a typo? >It is the name of the git repository on git.php.net. There were several other repos for PECL, bug tracker, docs in multiple languages, etc. I have added support for a static list that maps git.php.net names to GitHub repo under `php` organization namespace. oh i see. fwiw, your implementation looks more professional / enterprise-y :) On Tue, 5 Oct 2021 at 15:43, Ayesh Karunaratne wrote: > > here is an initial implementation: > > > https://github.com/divinity76/git-php-net-redirector/blob/main/src/redire= ctor.php > > it is just a minimum-effort implementation, anyone feel free to make > > something better (also i have no idea how the "p" argument is supposed = to > > be parsed, so i just guessed) > > > > it passes "Stanislav Malyshev"'s initial sample url, but it probably > fails > > on any other formats, if anyone has test urls, share em > > > > > > > > On Mon, 4 Oct 2021 at 08:38, Hans Henrik Bergan > > wrote: > > > > > >So who's going to work on it? Doesn't make sense to have 5 people wo= rk > > > > on it independently from each other ;-) > > > > > > if nobody else wants to do it, i can make an initial implementation o= n > > > october 9th (6 days from now), > > > > > > but wouldn't surprise me at all if someone else wants to do it ^^ > > > > > > > > > On Mon, 4 Oct 2021 at 08:01, Andreas Heigl wrote: > > > > > >> Hey all. > > >> > > >> On 04.10.21 07:52, Hans Henrik Bergan wrote: > > >> > there's also plenty of broken links on reddit to git.php.net , ref > > >> > https://www.google.com/search?q=3Dgit.php.net+site%3Areddit.com > > >> > > > >> > it wouldn't be hard to set up a redirector parsing commit ids out > of the > > >> > url and redirecting to github, > > >> > +1 from me. > > >> > > >> So who's going to work on it? Doesn't make sense to have 5 people wo= rk > > >> on it independently from each other ;-) > > >> > > >> Cheers > > >> > > >> Andreas > > >> -- > > >> ,,, > > >> (o o) > > >> > +---------------------------------------------------------ooO-(_)-Ooo-+ > > >> | Andreas Heigl > | > > >> | mailto:andreas@heigl.org N 50=C2=B022'59.5" E > 08=C2=B023'58" | > > >> | https://andreas.heigl.org > | > > >> > +---------------------------------------------------------------------+ > > >> | https://hei.gl/appointmentwithandreas > | > > >> > +---------------------------------------------------------------------+ > > >> > > > > > > Hi Stanislav/Hans, > Thanks for opening this conversation and the initial implementation. > > Having worked with a few cgit repositories before, I happen to recall > some of the other URL patterns. I worked on a similar implementation > to Hans's at https://github.com/Ayesh/git-php-redirect > > > something better (also i have no idea how the "p" argument is supposed = to > > be parsed, so i just guessed) > > It is the name of the git repository on git.php.net. There were > several other repos for PECL, bug tracker, docs in multiple languages, > etc. I have added support for a static list that maps git.php.net > names to GitHub repo under `php` organization namespace. > > In addition to the URL patterns Hans have covered > (p=3Dphp-src;h=3DHEX{40}), I thought to add a few more patterns: > > - FROM: http://git.php.net/?p=3Dphp-src.git;a=3Dcommit;h=3D5af586be ( > `/[a-z0-9]{7,}$/` ) > TO: https://github.com/php/php-src/commit/5af586be > > - FROM: > https://git.php.net/?p=3Dphp-src.git;a=3Dshortlog;h=3Drefs/tags/php-8.0.0= RC2 > TO: https://github.com/php/php-src/releases/tag/php-8.1.0RC3 > > - FROM: > https://git.php.net/?p=3Dphp-src.git;a=3D{tree,log,shortlog};h=3Drefs/hea= ds/master;hb=3Drefs/heads/master > TO: https://github.com/php/php-src/{tree,commits,commits}/master > > - FROM: http://git.php.net/?p=3Dphp-src.git;a=3Dlog > TO: https://github.com/php/php-src > > Cheers, > Ayesh. > --000000000000d502b805cd9d3628--