Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116211
MIME-Version: 1.0
References: <bcd64d76-aa73-893a-2603-447785b2e175@wikimedia.org>
In-Reply-To: <bcd64d76-aa73-893a-2603-447785b2e175@wikimedia.org>
Date: Mon, 4 Oct 2021 12:08:08 +0200
Message-ID: <CAF+90c8Cv-Tf791ZOo6tSnbY7fqDbj-Am=zZBUN4+43BFxbpAg@mail.gmail.com>
To: Tim Starling <tstarling@wikimedia.org>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000eec57c05cd84173e"
Subject: Re: [PHP-DEV] [RFC] Locale-independent case conversion
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000eec57c05cd84173e
Content-Type: text/plain; charset="UTF-8"

On Thu, Sep 23, 2021 at 8:32 AM Tim Starling <tstarling@wikimedia.org>
wrote:

> Please consider my RFC for locale-independent case conversion.
>
> https://wiki.php.net/rfc/strtolower-ascii
> https://github.com/php/php-src/pull/7506
>
> The RFC and associated PR ended up going some way beyond the original
> scope, because for consistency, it's best if everything has the same
> concept of case folding. I saw this as an opportunity to clean up a
> common kind of locale-dependence in PHP which was previously inconsistent.
>
> So not only will strtolower() and strtoupper() become
> locale-independent, converting only ASCII, but also stristr, stripos,
> strripos, lcfirst, ucfirst, ucwords, str_ireplace, the array sorting
> functions with SORT_FLAG_CASE, and array_change_key_case.
>
> Also, I changed a number of internal functions to use ASCII case
> folding, giving rise to a range of effects in callers throughout the
> core tree. The effects are all documented in the RFC.
>
> I am proposing that locale-sensitive case conversion be provided with
> the new names ctype_tolower() and ctype_toupper(). Those names might
> seem odd at first glance, but they are wrappers for functions in
> ctype.h and work in a very similar way to the rest of the ctype extension.
>

Hi Tim,

Thanks for creating this proposal, it looks great!

I think this is a very beneficial change, and the amount of incorrect
locale-dependent calls we had just in php-src further convinced me of this:
We're generally aware of the problem, and we still made this mistake. Many
times.

The only open question I have is regarding the ctype_* functions. One might
argue that these functions should be locale-independent as well. Certainly,
whenever I have used ctype_digit() I only intended it to match [0-9]. It
seems like some people try to use ctype_alpha() in a locale-sensitive way (
https://stackoverflow.com/questions/19929965/php-setlocale-not-working-for-ctype-alpha-check)
and then fail because it doesn't support UTF-8.

Regards,
Nikita

PS: Regarding escapeshellarg(), are you aware of the array command support
for proc_open() that was added in PHP 7.4? That does away the need to
escape arguments.

--000000000000eec57c05cd84173e--