Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:1162
Return-Path: <sascha@schumann.cx>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 42368 invoked from network); 2 May 2003 11:41:12 -0000
Received: from unknown (HELO milton.schell.de) (217.160.72.35)
  by pb1.pair.com with SMTP; 2 May 2003 11:41:12 -0000
Received: (qmail 16868 invoked by uid 501); 2 May 2003 11:41:11 -0000
Received: from unknown (HELO eco.foo) (80.143.15.128)
  by kdserv.de with SMTP; 2 May 2003 11:41:11 -0000
Received: from localhost (localhost [127.0.0.1])
	by eco.foo (Postfix) with ESMTP
	id 9AEDA45192; Fri,  2 May 2003 13:41:09 +0200 (CEST)
Date: Fri, 2 May 2003 13:41:09 +0200 (CEST)
X-X-Sender: sas@eco.foo
To: Wez Furlong <wez@thebrainroom.com>
Cc: internals@lists.php.net
In-Reply-To: <Pine.LNX.4.53.0305021150370.7207@zaneeb.brainnet.i>
Message-ID: <Pine.LNX.4.53.0305021334000.358@eco.foo>
References: <Pine.LNX.4.53.0305020044470.409@eco.foo>
 <Pine.LNX.4.53.0305021150370.7207@zaneeb.brainnet.i>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [PHP-DEV] [PATCH] Deprecate use of stdio
From: sascha@schumann.cx (Sascha Schumann)

On Fri, 2 May 2003, Wez Furlong wrote:

> +1 from me, but we need to make an extra effort to stress test the
> lexer (the ini file parser as well as the language parser) in our QA
> process.

    In our what?

    A patched PHP inside of thttpd does not show any anomalies
    after 100K ab requests:

    test.php:

    <?php

    require "bar";
    include "foo";
    include "notthere";

    bar:

    <?echo "hi";

    foo:

    <?phpinfo();

    As I mentioned earlier, including from URLs appears to be
    broken even without my patches (we could call that a security
    feature).

> Also, for the sake of binary compatibility (not sure just how much of an
> issue this is here), its "nicer" to add the zend_open function pointer
> to the end of the utility functions structure, rather than in the
> middle.

    Moved.  It would only affect applications which statically
    initialize the structure.

    - Sascha