Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116176
MIME-Version: 1.0
References: <CAJp_myX3J8gUb3885KAdEz+xokpZ_mz1Gs_DrN2Tp+JYfewcEw@mail.gmail.com>
 <edc0eb69-457e-4318-5f53-9b7f7dceee7f@processus.org> <12f54268-1a63-ad10-de01-ee03a6845ed9@seld.be>
In-Reply-To: <12f54268-1a63-ad10-de01-ee03a6845ed9@seld.be>
Date: Sun, 26 Sep 2021 21:30:37 +0700
Message-ID: <CAEZPtU7xBbH_Fbt15rqBVOHiJbopsC1oGaDV7wtH1mY4n3xAFA@mail.gmail.com>
To: Jordi Boggiano <j.boggiano@seld.be>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ab5a2505cce6d3e1"
Subject: Re: [PHP-DEV] BC breaking changes in PHP 8.1
From: pierre.php@gmail.com (Pierre Joye)

--000000000000ab5a2505cce6d3e1
Content-Type: text/plain; charset="UTF-8"

On Sun, Sep 26, 2021, 7:42 PM Jordi Boggiano <j.boggiano@seld.be> wrote:

>
> > I'm surprised that is_resource() returns false for resource objects,
> > does anyone knows why it wouldn't return true in such case ?
> >
> > This is a very weird behavior, I'd expect it to return true, moreover
> > this is the most annoying detail of this BC break, in my opinion.
> >
> > I have lots of code using is_resource() but I usually don't bother
> > checking for type (maybe I'm doing it wrong). But I'd also expect
> > get_resource_type() to be deprecated somehow and return
> > backward-compatible values for converted resources to objects.
>
> Right, having is_resource return true for resourcey objects would have
> prevented all resource-related errors I ran into with php8.0 migration I
> believe. That'd be a welcome improvement/fix for 8.1.
>

that was proposed but purity won if I remember correctly.

That's kind of defeat the initial goal (attempt) of yearly releases. Now I
feel like we introduced more, small or big, bc in minor releases in the
name of purity. That counter balance the yearly release with no bc from a
migration pace pov.

best,
Pierre

>

--000000000000ab5a2505cce6d3e1--