Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116175
MIME-Version: 1.0
References: <CAJp_myX3J8gUb3885KAdEz+xokpZ_mz1Gs_DrN2Tp+JYfewcEw@mail.gmail.com>
 <edc0eb69-457e-4318-5f53-9b7f7dceee7f@processus.org> <12f54268-1a63-ad10-de01-ee03a6845ed9@seld.be>
In-Reply-To: <12f54268-1a63-ad10-de01-ee03a6845ed9@seld.be>
Date: Sun, 26 Sep 2021 15:00:25 +0200
Message-ID: <CAOWwgpkT3Wq2abGtSC8KaAHjfKQC=WnVXSycvbYaZvfOM=hVHA@mail.gmail.com>
To: Jordi Boggiano <j.boggiano@seld.be>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000001cc10605cce5919a"
Subject: Re: [PHP-DEV] BC breaking changes in PHP 8.1
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--0000000000001cc10605cce5919a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Le dim. 26 sept. 2021 =C3=A0 14:42, Jordi Boggiano <j.boggiano@seld.be> a =
=C3=A9crit :

>
> > I'm surprised that is_resource() returns false for resource objects,
> > does anyone knows why it wouldn't return true in such case ?
> >
> > This is a very weird behavior, I'd expect it to return true, moreover
> > this is the most annoying detail of this BC break, in my opinion.
> >
> > I have lots of code using is_resource() but I usually don't bother
> > checking for type (maybe I'm doing it wrong). But I'd also expect
> > get_resource_type() to be deprecated somehow and return
> > backward-compatible values for converted resources to objects.
>
> Right, having is_resource return true for resourcey objects would have
> prevented all resource-related errors I ran into with php8.0 migration I
> believe. That'd be a welcome improvement/fix for 8.1.
>

I'm not sure about this one: is_resource($foo) ? get_resource_type() is
pretty common. Also this would break some expectations with gettype($foo)

Nicolas

>

--0000000000001cc10605cce5919a--