Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116174
To: internals@lists.php.net
References: <CAJp_myX3J8gUb3885KAdEz+xokpZ_mz1Gs_DrN2Tp+JYfewcEw@mail.gmail.com>
 <edc0eb69-457e-4318-5f53-9b7f7dceee7f@processus.org>
Message-ID: <12f54268-1a63-ad10-de01-ee03a6845ed9@seld.be>
Date: Sun, 26 Sep 2021 14:42:30 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <edc0eb69-457e-4318-5f53-9b7f7dceee7f@processus.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [PHP-DEV] BC breaking changes in PHP 8.1
From: j.boggiano@seld.be (Jordi Boggiano)


> I'm surprised that is_resource() returns false for resource objects, 
> does anyone knows why it wouldn't return true in such case ?
>
> This is a very weird behavior, I'd expect it to return true, moreover 
> this is the most annoying detail of this BC break, in my opinion.
>
> I have lots of code using is_resource() but I usually don't bother 
> checking for type (maybe I'm doing it wrong). But I'd also expect 
> get_resource_type() to be deprecated somehow and return 
> backward-compatible values for converted resources to objects.

Right, having is_resource return true for resourcey objects would have 
prevented all resource-related errors I ran into with php8.0 migration I 
believe. That'd be a welcome improvement/fix for 8.1.

Best,
Jordi

-- 
Jordi Boggiano
@seldaek - https://seld.be