Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116151
To: PHP Developers Mailing List <internals@lists.php.net>
References: <CAJp_myX3J8gUb3885KAdEz+xokpZ_mz1Gs_DrN2Tp+JYfewcEw@mail.gmail.com>
Message-ID: <50e931e6-a48f-19e8-402e-359fe7dd2a82@nunninger.info>
Date: Thu, 23 Sep 2021 23:29:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJp_myX3J8gUb3885KAdEz+xokpZ_mz1Gs_DrN2Tp+JYfewcEw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] BC breaking changes in PHP 8.1
From: thomas@nunninger.info (Thomas Nunninger)

Hi,

Am 22.09.21 um 15:29 schrieb Matthew Weier O'Phinney:
> Here's the issue: while overall, I like the move to resource objects,
> introducing them in a MINOR release is hugely problematic.
> 
> Previously, you would do constructs such as the following:
> 
>      if (! is_resource($resource) || get_resource_type($resource) !==
> $someSpecificType) {
>          // skip a test or raise an exception
>      }
> 
> Resource objects, however:
> 
> - Return `false` for `is_resource()` checks.
> - Raise a warning for `get_resource_type()` checks, and/or report the
> resource object class name — which differs from the previous resource names
> in all cases.

Would it be helpful if is_resource() raises an error if a resource 
object is provided as argument instead of returning false? (Should that 
be limited to the newly introduced resource objects in 8.1? Would a 
deprecation be enough?)

Of course, existing code would not work with that change. But you should 
be able to spot the error and fix it.

It should be possible to write code that works with PHP < 8.1 and >= 
8.1. Combined with Rowans idea of a Resource base class or interface 
that might even be easier?

(I assume it's of no additional help to change get_resource_type() to 
accept resource objects and return the same result as the former, 
corresponding resource type.)

Regards
Thomas