Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116149
To: internals@lists.php.net
References: <CAJp_myX3J8gUb3885KAdEz+xokpZ_mz1Gs_DrN2Tp+JYfewcEw@mail.gmail.com>
 <CAF+90c_JR1mUrgHFkfYYZi2TuSmkaF3hmvT03rfW7kGnhkZf6Q@mail.gmail.com>
Message-ID: <df8d14b8-9b17-c471-7c77-b7ee16d0ec4b@gmail.com>
Date: Thu, 23 Sep 2021 18:47:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAF+90c_JR1mUrgHFkfYYZi2TuSmkaF3hmvT03rfW7kGnhkZf6Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] BC breaking changes in PHP 8.1
From: rowan.collins@gmail.com (Rowan Tommins)

On 23/09/2021 17:52, Nikita Popov wrote:
> If we dropped
> all non-deprecation changes from PHP 8.1, the upgrade would be a bit
> easier, but not by much. This is not where the main cost is.


Be that as it may, the question remains whether *the particular case of 
is_resource() and get_resource_type()* could be made easier.

Was the option of having a "Resource" base class or interface ever 
discussed? If it had a method called something like 
"getResourceTypeString()" then get_resource_type() could do (the 
internal equivalent of):

if ( is_resource($arg) ) {
    // current logic
}
elseif ( is_object($arg) && $arg instanceOf Resource ) {
     return $arg->getResourceTypeString();
}


I suspect as 8.0 and then 8.1 gain adoption, there is going to be a lot 
of confusion around the resource -> object change. Most users probably 
don't really know what a "resource", they just know the boilerplate to use.

Regards,

-- 
Rowan Tommins
[IMSoP]