Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116140
To: tyson andre <tysonandre775@hotmail.com>,
 "internals@lists.php.net" <internals@lists.php.net>
References: <b61f3e9e-c0f3-a490-6750-b9b480cae539@wikimedia.org>
 <DM6PR07MB6618B2C1C6DC53F01B8780D5F9DD9@DM6PR07MB6618.namprd07.prod.outlook.com>
Message-ID: <b594cf70-9efe-9bec-7838-184e99cfcfd8@wikimedia.org>
Date: Thu, 23 Sep 2021 15:40:22 +1000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <DM6PR07MB6618B2C1C6DC53F01B8780D5F9DD9@DM6PR07MB6618.namprd07.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Make strtolower/strtoupper just do ASCII
From: tstarling@wikimedia.org (Tim Starling)

On 19/9/21 12:33 am, tyson andre wrote:
> When implementing this, Zend/Optimizer/sccp.c has optimizations for functions such as str_contains, etc to optimize.
> After removing locale dependence, those optimizations could be safely added for functions that would be locale independent as a result of your change.
> - This would allow eliminating more dead code, and make code calling those functions (on constant arguments) faster by caching the resulting strings in opcache.

I couldn't make this work. Even after setting
opcache.optimization_level to 0x7FFFFFBF (pass 6 will not run unless
pass 7 is disabled), zend_dfa_optimize_op_array() is called with
call_map=NULL, so ct_eval_func_call() is never entered. I'll leave
this change for someone who is able to test it (or for someone braver
than me).

-- Tim Starling