Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116131
Message-ID: <edc0eb69-457e-4318-5f53-9b7f7dceee7f@processus.org>
Date: Wed, 22 Sep 2021 16:06:33 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Matthew Weier O'Phinney <mweierophinney@gmail.com>,
 PHP Developers Mailing List <internals@lists.php.net>
References: <CAJp_myX3J8gUb3885KAdEz+xokpZ_mz1Gs_DrN2Tp+JYfewcEw@mail.gmail.com>
In-Reply-To: <CAJp_myX3J8gUb3885KAdEz+xokpZ_mz1Gs_DrN2Tp+JYfewcEw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] BC breaking changes in PHP 8.1
From: pierre-php@processus.org (Pierre)

Le 22/09/2021 à 15:29, Matthew Weier O'Phinney a écrit :
> Yesterday, I opened an issue regarding a change in the pgsql extension (
> https://bugs.php.net/bug.php?id=81464).
>
> PHP 8.0 introduced the concept of "resource objects". Where previously we
> would have resources, and use `get_resource_type()` when we needed to
> differentiate various resources, resource objects give us immutable objects
> instead that allow us to type hint. Personally, I think this is wonderful!
>
> The rollout for 8.0 was incomplete, however, and only touched on something
> like 4-6 different resource types. Still, a good start.
>
> With PHP 8.1, we're seeing the addition of more of these, and it was
> encountering one of those changes that prompted the bug I previously linked
> to.
>
> Here's the issue: while overall, I like the move to resource objects,
> introducing them in a MINOR release is hugely problematic.
>
> Previously, you would do constructs such as the following:
>
>      if (! is_resource($resource) || get_resource_type($resource) !==
> $someSpecificType) {
>          // skip a test or raise an exception
>      }
>
> Resource objects, however:
>
> - Return `false` for `is_resource()` checks.
> - Raise a warning for `get_resource_type()` checks, and/or report the
> resource object class name — which differs from the previous resource names
> in all cases.

Hello,

I'm surprised that is_resource() returns false for resource objects, 
does anyone knows why it wouldn't return true in such case ?

This is a very weird behavior, I'd expect it to return true, moreover 
this is the most annoying detail of this BC break, in my opinion.

I have lots of code using is_resource() but I usually don't bother 
checking for type (maybe I'm doing it wrong). But I'd also expect 
get_resource_type() to be deprecated somehow and return 
backward-compatible values for converted resources to objects.

Regards,

--

Pierre