Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116126
To: tyson andre <tysonandre775@hotmail.com>,
 "internals@lists.php.net" <internals@lists.php.net>
References: <b61f3e9e-c0f3-a490-6750-b9b480cae539@wikimedia.org>
 <DM6PR07MB6618B2C1C6DC53F01B8780D5F9DD9@DM6PR07MB6618.namprd07.prod.outlook.com>
Message-ID: <2e2512c8-8e3d-6e9e-ff3f-278801c0c4df@wikimedia.org>
Date: Wed, 22 Sep 2021 22:57:01 +1000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <DM6PR07MB6618B2C1C6DC53F01B8780D5F9DD9@DM6PR07MB6618.namprd07.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Make strtolower/strtoupper just do ASCII
From: tstarling@wikimedia.org (Tim Starling)

On 19/9/21 12:33 am, tyson andre wrote:
> When implementing this, Zend/Optimizer/sccp.c has optimizations for functions such as str_contains, etc to optimize.
> After removing locale dependence, those optimizations could be safely added for functions that would be locale independent as a result of your change.
> - This would allow eliminating more dead code, and make code calling those functions (on constant arguments) faster by caching the resulting strings in opcache.

Thanks, I will do that.

> The function `zend_string_tolower` can safely be used to efficiently convert strings to lowercase in a case-insensitive way.
> (zend_string_toupper hasn't been needed yet due to not yet having any use cases in php-src's internals, but could be added in such a PR)

I uploaded my work so far and made a PR. It already has
zend_string_toupper.

-- Tim Starling