Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116106
MIME-Version: 1.0
References: <DM6PR07MB6618C8CD95260D59399D986EF9DF9@DM6PR07MB6618.namprd07.prod.outlook.com>
 <CAM0Ccxjon3Zoa1h39w-bV8h+vHO2JSGu6xkv6+errwFhnQXOfA@mail.gmail.com>
In-Reply-To: <CAM0Ccxjon3Zoa1h39w-bV8h+vHO2JSGu6xkv6+errwFhnQXOfA@mail.gmail.com>
Date: Mon, 20 Sep 2021 12:07:57 +0200
Message-ID: <CADyq6s+WvSDQ6Ky+uWYygEnLOrEO=id5Z3xRxHg4NiNpP7RRYw@mail.gmail.com>
To: Eugene Sidelnyk <zsidelnik@gmail.com>
Cc: tyson andre <tysonandre775@hotmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000325e7705cc6a759b"
Subject: Re: [PHP-DEV] Proposal: Adding an ARRAY_FILTER_REINDEX flag to array_values
From: ocramius@gmail.com (Marco Pivetta)

--000000000000325e7705cc6a759b
Content-Type: text/plain; charset="UTF-8"

On Mon, Sep 20, 2021 at 12:02 PM Eugene Sidelnyk <zsidelnik@gmail.com>
wrote:

> From my experience it is not that easy to locate bug like this.
>

Heyo, just a tip for you (and others in this thread), but if you use
`vimeo/psalm` and declare a `list<T>` for a type, then `array_filter()`
that are missing an `array_values()` around it will be caught :)

```php
/** @return list<mixed> */
function foo(array $input): array {
    return array_filter($input);
}
```

Will produce:

```
INFO: MixedReturnTypeCoercion - 5:12 - The type 'array<array-key,
non-empty-mixed>' is more general than the declared return type
'list<mixed>' for foo
```

See https://psalm.dev/r/f9c51f72c2

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--000000000000325e7705cc6a759b--