Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116097
To: "internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: Proposal: Adding an ARRAY_FILTER_REINDEX flag to array_values
Thread-Index: AQHXrVaY5NYiU2cHn0abe/KgvhewOg==
Date: Sun, 19 Sep 2021 13:11:47 +0000
Message-ID:
 <DM6PR07MB6618C8CD95260D59399D986EF9DF9@DM6PR07MB6618.namprd07.prod.outlook.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
suggested_attachment_session_id: 52c36232-1dea-9563-0fb6-ba0d73fc66d9
x-tmn:
 [BTKk3RcIGw80k7xXHUxq9Un+hZazaPOEdk5PvEG1dY8j7HU6dWqGarLLTO5wt5KQ/AY08BcADqw=]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8b625c8b-8237-4857-8503-08d97b6f096c
x-ms-traffictypediagnostic: DM6PR07MB4587:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 4LJpalLTVB+xPBMf5QgO3ZNJ4rPcVBq0PvK9BkHheqcVe8RHGZKsOdrnyUUokFkeVpnU6Prkp9uMjWX/dpfdYjfsBti8+YVNhVEuKv9sMQSn3k+v7lWGyNyWRTQaZQde97bxT0YZDVix72fV8aynBmNiiD19+DFetoS+pqUyMTZ2LStKcsDISfpbtwsvSRhfLe16T079GO9cIhWDnflCb+4FkWsGuVf92lXMQqc3tkFcC3GiLCF1uf29cvuoAFfDO7sRj+dAv4atRwA5u1Wds2A4lJKN/bMmqD4br5m3NpwyCZLCyQtXW08dDScUBtVt8EHuOP7hfDvVvbHGdGzyRogS4u++T5BoWgWBHnnr2PcVCDwLQHM8A7xzdkkkYuPyYhLROdAk4Q9G829FRKwSF7KAdQHZvFijD+05RZlfqfBvtHe6SZypmfKuVGmFXdpVVtaRK00i9TEEAVGQt3Nz0Wg37oeyoNgcz9YfS003CQk=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 QhHP41YEMb+va4dRUBsowmbfsGtRWFc1rSVWC0o9nADBvQiI6g3Fb32EWgx3IQ9smsxxipBDmGConBKKIT1GFoZ4wCxCm7LRersFnqHM34/ItCEuIJCd8k7poBa4+USm34RivTLSi2rWTNJhIZh2r1W11uwhtTebCi2iJ7V/SIyeTJgPuyf1d+TZ0gVXNKAkmvaW5azp64+tHjCNZ9MwIA==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-35401.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR07MB6618.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b625c8b-8237-4857-8503-08d97b6f096c
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2021 13:11:47.8869
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB4587
Subject: Proposal: Adding an ARRAY_FILTER_REINDEX flag to array_values
From: tysonandre775@hotmail.com (tyson andre)

Hi internals,=0A=
=0A=
Currently, array_filter will always return the original keys.=0A=
This often requires an additional wrapping call of array_values(array_filte=
r(...)) to reindex the keys and return a list.=0A=
(or applications may not realize there will be gaps in the keys until it ca=
uses a bug or unexpected JSON encoding, etc.)=0A=
=0A=
PHP is also more memory/time efficient at creating packed arrays than it is=
 at creating associative arrays.=0A=
=0A=
What are your thoughts on adding `ARRAY_FILTER_REINDEX`, to ignore the orig=
inal int/string keys and replace them with `0, 1, 2, ...`=0A=
=0A=
```=0A=
php > echo json_encode(array_filter([5,6,7,8], fn($value) =3D> $value % 2 >=
 0));=0A=
{"0":5,"2":7}=0A=
// proposed flag=0A=
php > echo json_encode(array_filter([5,6,7,8], fn($value) =3D> $value % 2 >=
 0, ARRAY_FILTER_REINDEX));=0A=
[5,7]=0A=
```=0A=
=0A=
https://www.php.net/array_filter already has the `int $mode =3D 0` which ac=
cepts the bit flags `ARRAY_FILTER_USE_KEY` and `ARRAY_FILTER_USE_BOTH`=0A=
These could be then be combined with the proposed bit flag `ARRAY_FILTER_RE=
INDEX`, e.g. to filter an array based on both the array keys and values, an=
d return a list without gaps.=0A=
(and if $callback is null, this would return a list containing only the tru=
thy values)=0A=
=0A=
Thoughts? =0A=
=0A=
Thanks,=0A=
Tyson=