Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116093
To: "internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: [PHP-DEV] RFC: Add `final class Vector` to PHP
Thread-Index: AQHXq2Dr5ROExEhu802SAlX6zd1M+6upRoIAgAEp0s0=
Date: Sat, 18 Sep 2021 23:26:31 +0000
Message-ID:
 <DM6PR07MB6618581DE5810D10511104FFF9DE9@DM6PR07MB6618.namprd07.prod.outlook.com>
References:
 <DM6PR07MB6618D41DE7680BE2BE8086DAF9DD9@DM6PR07MB6618.namprd07.prod.outlook.com>
 <BC23FD6B-DE7C-49F2-B735-2FEC8572B147@newclarity.net>
In-Reply-To: <BC23FD6B-DE7C-49F2-B735-2FEC8572B147@newclarity.net>
Accept-Language: en-CA, en-US
Content-Language: en-CA
suggested_attachment_session_id: 04900e78-9380-b1a2-e9a1-8d3d5c14ff00
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn:
 [CKP2HQc9sEtScHqaEvc48uUQz/1gIqBgMRb3FpaSCP1rzt2fVc9bHpfPT0zIXf9Qlu182qpPnvM=]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3757897d-89b7-488b-f4a1-08d97afbbf54
x-ms-traffictypediagnostic: DM5PR07MB3866:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 x2TQFLsx3407C5m0TBd46VpOEZm2d4WbT7G0DTqlb+rOShcHWSuDcsAy9Th8D7l7BWRDymkgOtbGSCjwlpYo7sgCZk0Xr9vWALVHlA+D46dy34WBFJBTISqejLTJFGTheDCneq4QTVTvQHH/WPqerB1DYkqYEGvbyi0s93qG5hgfCLW/a+e64VIzUGFk0W41M9FPMItmOaVLlm7dwi2tpcAdNQqhkQTBZTAdOSkPeYPtAljTgFvnN2+xFah6Vv0uGTTUtD4qGZi9E8rW7v1KS56kAl29pxtv2zSofDo+fQV5sJDW1T3/W2ze3rUZghg5jkd49fA8+veMv+p/xf9iRFVXCaPWQ8AGDa0GtN1FR+EprKVkGmTT/m1sHgHx2ABiDt+f4vc0qSv0jTJ5NkBykqRTq0w4s24R1LGDzaF88y7atlI3T38zXd71aVRb4MGe
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 VoKVGsBA84BIpONWiRx5PX0LANumR4flE/+RN0Hrsy38Wdgzb3OKGWS+RGpILTMHJfG8r/tcIfWJOCQWXuldjd+Tkx7Vvw1/wkWlPuGWLEQB7fgIIkziHfGWDpwOOgt0Ye+j8bS4E78T2RbxgnuYf7GI7fe1YLxaCPUr/6aykxul5qGqLSPJ3BKsnJy1vQyRzPQAkOkfzFhHWGXH12aXbw==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-35401.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR07MB6618.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 3757897d-89b7-488b-f4a1-08d97afbbf54
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2021 23:26:31.4801
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3866
Subject: Re: [PHP-DEV] RFC: Add `final class Vector` to PHP
From: tysonandre775@hotmail.com (tyson andre)

Hi Mike Schinkel,=0A=
=0A=
> Given there seems to be a lot of concern about the approach the RFC propo=
ses would it not address the concerns about memory usage and performance if=
 several methods were added to SplFixedArray instead (as well as functions =
like indexOf(), contains(), map(), filter(), JSONSerialize(), etc., or simi=
lar):=0A=
> =0A=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A=
> =0A=
> setCapacity(int) =97 Sets the Capacity, i.e. the maximum Size before resi=
ze=0A=
> getCapacity():int =97 Gets the current Capacity.=0A=
> =0A=
> setGrowthFactor(float) =97 Sets the Growth Factor for push(). Defaults to=
 2=0A=
> getGrowthFactor():float =97 Gets the current Growth Factor=0A=
> =0A=
> pop([shrink]):mixed =97 Returns [Size] then subtracts 1 from Size. If (bo=
ol)shrink passed then call shrink().=0A=
> push(mixed) =97 Sets [Size]=3Dmixed, then Size++, unless Size=3DCapacity =
then setSize(n) where n=3Dround(Size*GrowthFactor,0) before Size++.=0A=
> =0A=
> grow([new_capacity]) =97 Increases memory allocated. Sets Capacity to Siz=
e*GrowthFactor or new_capacity.=0A=
> shrink([new_capacity]) =97 Reduces memory allocated. Sets Capacity to cur=
rent Size or new_capacity.=0A=
> =0A=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A=
> =0A=
> If you had these methods then I think you would get the memory and perfor=
mance improvements you want, and if you really want a final Vector class fo=
r your own uses you could roll your own using inheritance or containment.=
=0A=
=0A=
I asked 8 months ago about `push`/`pop` in SplFixedArray. The few responses=
 were unanimously opposed to SplFixedArray being repurposed like a vector,=
=0A=
the setSize functionality was treated more like an escape hatch and it was =
conceptually for fixed-size data.=0A=
=0A=
I also believe adding a configurable growth factor would be excessive for a=
 high level language.=0A=
=0A=
Thanks,=0A=
Tyson=0A=