Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116073
To: "internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: [PHP-DEV] RFC: Add `final class Vector` to PHP
Thread-Index: AQHXq2Dr5ROExEhu802SAlX6zd1M+6un3yqAgABWubc=
Date: Fri, 17 Sep 2021 13:54:53 +0000
Message-ID:
 <DM6PR07MB66189B34E9924A7347D649B3F9DD9@DM6PR07MB6618.namprd07.prod.outlook.com>
References:
 <DM6PR07MB6618D41DE7680BE2BE8086DAF9DD9@DM6PR07MB6618.namprd07.prod.outlook.com>
 <B4A42C87-0F0D-4561-B4E2-E8DE655E126E@cschneid.com>
In-Reply-To: <B4A42C87-0F0D-4561-B4E2-E8DE655E126E@cschneid.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
suggested_attachment_session_id: 960f949a-b19b-43b0-e6c4-09d6cfd497af
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [Kal1bpkutMNH/maa3aU6loa1FDVvPx/KXOY3Qq6ZxHE65qGhyTfO5+NgkvjiiHRF]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ecf458c9-2a61-4395-c5be-08d979e2b9c4
x-ms-traffictypediagnostic: DM6PR07MB7050:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 c6WyRenCL49LiArD/GKLtGb4RC0WLsaz5rgWmmEoTuXMzCLDdmI2s1xye2YkvRAQ9edR7R5O1xdu2iTomevQAA5pBjdcnTfnRpndEFQ1AcHrg7T7gEnD0eSqADSrGYwasJZHIRopcmIVhPZNoNrTt47WyD1Lha9Gjy6NfpCmxfYWDpDDB1zVD8bUbfMe7iUgJEK7sAKs+Sbss+wxsDJJTw8Oumqw0ju3XZk5bLOPaK1jws97yoQBvTlgxonwRZcqinYMmdxi0RrVdHnsLaCqke7xzq47bH6eN6t1GzlKCGzfyisnZMyh2FJh97u3RMbI68eqpKa40YAU2CAvSXkKuXEn47e0ZICXxtl/TAKqqx9BBfKCTl5w+L+HpGWe+MIU1BM+Q6NOYaNtk9t+UzjOtEZ4N3To5BDVBo8RrShV36UeewEX0oM/PFp1n0IPGxzs4652oUu9DmDsgM46WQ+n5Ao/+xmEBs0HajpsBCI+6SE=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 /jSJrbHb0hosrBFgkFmwTHw1vegcS2mmmkbyHLZe4RCdZY/BUX0NPNDipwSC4VMy/s4YEEi0kNAR04SPJbMRJNSZcmGCdfR3FZfCwQy93ZJa6KXkvL2r4hIKYzihUTE4xwWZzfUIFZGVPesHUwVCHm/hWkZHe2sTHrgMa6ItY3IU/qt9J/nFeVFXx6U0Hx4DJgdtqbDkZlBEjnyMo/BRPA==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-35401.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR07MB6618.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: ecf458c9-2a61-4395-c5be-08d979e2b9c4
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2021 13:54:53.4736
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB7050
Subject: Re: [PHP-DEV] RFC: Add `final class Vector` to PHP
From: tysonandre775@hotmail.com (tyson andre)

Hi Christian Schenider,=0A=
=0A=
> First of all: I don't have a strong opinion on a Vector class being usefu=
l or necessary.=0A=
> =0A=
> But I have two comments about this RFC:=0A=
> =0A=
> 1. Using the very generic name Vector without any prefix/namespace seems =
dangerous and asking for BC breaks.=0A=
=0A=
I downloaded the top 400 composer packages with https://github.com/nikic/po=
pular-package-analysis/ and didn't find any classes named Vector.=0A=
=0A=
- Only php-cs-fixer extends SplFixedArray in one class. It can continue do =
so.=0A=
- I don't see other classes called Vector. Just stubs for `\Ds\Vector`.=0A=
=0A=
There are tradeoffs and objections to any possible choice of name I could m=
ake, including this or alternates.=0A=
=0A=
- Too likely to have conflicts=0A=
- Excessively long=0A=
- Open to adopting namespace but objecting to migrating existing classes (o=
r not doing so)=0A=
- Objecting to a specific choice =0A=
=0A=
> 2. I don't like that this class is final. The reasons given in https://wi=
ki.php.net/rfc/vector#final_class https://wiki.php.net/rfc/vector#final_cla=
ss seem unconvincing to me and restrict the usage of Vector in a way which =
makes me question the usefulness to a big enough part of the PHP community.=
=0A=
> These two reasons combined would make me reject the RFC at the current st=
age.=0A=
=0A=
There are alternatives such as making all/almost all of the methods final(e=
specially for reading and modifying array elements or basic properties of t=
he vector), but allowing extending the class.=0A=
=0A=
-=A0Still, I don't think that'd be very useful, and would make future final=
 method additions to Vector backwards incompatible.=0A=
- Trying to do everything (e.g. be extensible and handle all edge cases of =
extension) has often resulted in many spl data structures doing not anythin=
g very well(efficiently, correctly, or possible to make universal assumptio=
ns about or optimize in the future with opcache/the jit).=0A=
=0A=
While it is possible to extend ArrayObject and SplFixedArray, very few thin=
gs do that, and it'd generally lead to worse API design except in a few cas=
es.=0A=
(E.g. `UserList extends \Vector` wouldn't be able to enforce that inserted =
values are actually users with final methods)=0A=
=0A=
Thanks,=0A=
Tyson=0A=