Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116055
MIME-Version: 1.0
References: <DM6PR07MB6618D41DE7680BE2BE8086DAF9DD9@DM6PR07MB6618.namprd07.prod.outlook.com>
 <CAAKU0unuauCu+WscxLSKRpbqTAWb9F8gCF2=UiAA2xc15CL5XA@mail.gmail.com> <DM6PR07MB6618C99264E6155695D21C50F9DD9@DM6PR07MB6618.namprd07.prod.outlook.com>
In-Reply-To: <DM6PR07MB6618C99264E6155695D21C50F9DD9@DM6PR07MB6618.namprd07.prod.outlook.com>
Reply-To: Levi Morrison <levi.morrison@datadoghq.com>
Date: Thu, 16 Sep 2021 22:46:59 -0600
Message-ID: <CAAKU0umvrL1jFyex0h_QqMTcKC0qrGwrSTdJ0y3fFHY+74TWYA@mail.gmail.com>
To: tyson andre <tysonandre775@hotmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] RFC: Add `final class Vector` to PHP
From: internals@lists.php.net ("Levi Morrison via internals")

> > - `contains` also doesn't have a comparator.
>
> I was considering proposing `->any(callable)` and `->all(callable)` extensions if this passed.
> I'm not quite sure what you mean by a comparator for contains. There'd have to be a way to check if a raw closure is contained.

I mean that there isn't a way to provide a custom way to compare for
equality. One way to accomplish this is to have a signature like:
    function contains(T $value, ?callable(T, T):bool $comparator = null): bool

The same goes for `indexOf`.

> > - I don't know what `setSize(int $size)` does. What does it do if the
> > current size is less than `$size`? What about if its current size is
> > greater? I suspect this is about capacity, not size, but without docs
>  > I am just guessing.
>
> It's the same behavior as https://www.php.net/manual/en/splfixedarray.setsize.php . It's about size, not capacity.
>
> > Change the size of an array to the new size of size.
> > If size is less than the current array size, any values after the new size will be discarded.
> > If size is greater than the current array size, the array will be padded with null values.
>
> I'd planned to add phpdoc documentation and examples before starting a vote to document the behavior and thrown exceptions of the proposed methods.

I would rather see multiple methods like:
    function truncateTo(int $size)
    function padEnd(int $length, $value) // allows more than just null
    function padBeginning(int $length, $value)
And one or more for increasing/ensuring capacity without changing size.