Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116053
To: "internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: [PHP-DEV] RFC: Add `final class Vector` to PHP
Thread-Index: AQHXq2Dr5ROExEhu802SAlX6zd1M+6unhrKAgAAIYYw=
Date: Fri, 17 Sep 2021 03:33:34 +0000
Message-ID:
 <DM6PR07MB6618C99264E6155695D21C50F9DD9@DM6PR07MB6618.namprd07.prod.outlook.com>
References:
 <DM6PR07MB6618D41DE7680BE2BE8086DAF9DD9@DM6PR07MB6618.namprd07.prod.outlook.com>
 <CAAKU0unuauCu+WscxLSKRpbqTAWb9F8gCF2=UiAA2xc15CL5XA@mail.gmail.com>
In-Reply-To:
 <CAAKU0unuauCu+WscxLSKRpbqTAWb9F8gCF2=UiAA2xc15CL5XA@mail.gmail.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
suggested_attachment_session_id: cc6e2d19-6ab4-43f4-2c81-97ca924e4fe3
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn:
 [c0JAT1endA9tYHF2r2K7NTjIW0Y/x7oWwL9AIWvFului5TKaH0bQRKTvpXHA8J1LI+61iAm4UWw=]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 860c206d-a2a7-4088-1e7c-08d9798bedaa
x-ms-traffictypediagnostic: DM5PR07MB3178:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 O3FZWryqxr/+GbUdsTxkzmWXHukZih1Y216oWk9D5Haesp7uHXF4gaxAekQXHTXQGu5gOCwT7BarcXthWqYmHwTbl/rRcRlrZOax2v7W3ucoyuu/GHDhAzD7U8coSNvhBSmYIifAmpUzy4L5AWmoFC9ahYEDt088xkzCCubb1jkl7mMbUxoegfshAd6gYdGANGyaP10e9rZ6NZZ/XDa4oXoqvLzwhRvzv6i3C9DmcNpudSs/rSRD+S7HqbmEgz3w5BlYpx8EJNXoKPY6mvqlQlrLrGlpgh8eQNvP0L/phyYCxWoTuDidiYpFEXc7f/vf+8GSlUwdbJ2OcVn4kwTfVtso3gVw8PJyU3ljBW3MpyC1NKFKKLQgAcuCh6b3fyO8VIk3YTmrqRqlw7svTDpc6USlR6BP5B9XJ2kBouz2szhz5HQV8QU1fvEwFv/BvaMhUjh8uwE1WZ5uDHKb0LOKsVEDkz31Q3nuryNeX0iOFwo=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 Ji+cyOzx8D7G1C2tAlYM/oQY8/ovnM8rpa1J+poq+bNNSz+C2iKKELLzDJEoMjBnl5cW7d2EAKilXEqaG1/pev3mTHQZw2Y8fjhrxcKCtDbF6nAtQV0oapqHx6jqvxGVHkBc8iIeD6wtK2lk0mn1W/7PsfaJLk8/tZ5ge+q/9zpJZQpRP6wToCGRJGfJBjxxWexgkhe6BqlCrF3uRvZfzg==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-35401.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR07MB6618.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 860c206d-a2a7-4088-1e7c-08d9798bedaa
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2021 03:33:34.4030
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3178
Subject: Re: [PHP-DEV] RFC: Add `final class Vector` to PHP
From: tysonandre775@hotmail.com (tyson andre)

Hi Levi Morrison,=0A=
=0A=
> I'm okay with a final Vector class in general. I don't love the=0A=
> proposed API but don't hate it either. Feedback on that at the end.=0A=
> =0A=
> What I would _love_ is a `vec` type from hacklang, which is similar to=0A=
> this but pass-by-value, copy-on-write like an array. Of course, this=0A=
> would require engine work and I understand it isn't as simple to add.=0A=
=0A=
Yeah, as mentioned in https://wiki.php.net/rfc/vector#adding_a_native_type_=
instead_is_vec , it would require a massive amount of work.=0A=
=0A=
- A standard library for dealing with `vec`, filtering it, etc=0A=
- Userland libraries and PECLs would need to deal with a third complex type=
 different from array/object that probably couldn't be implicitly =0A=
- Extensive familiarity with opcache and the JIT for x86 and other platform=
s beyond what I have=0A=
- Willingness to do that with the uncertainty the final implementation woul=
d get 2/3 votes with backwards compatibility objections, etc.=0A=
=0A=
> Feedback on API:=0A=
> =0A=
> -=A0 `indexOf` returning `false` instead of `null` when it cannot be=0A=
> found. If we are keeping this method (which I don't like, because=0A=
> there's no comparator), please return `null` instead of false. The=0A=
> language has facilities for working with null like `??`, so please=0A=
> prefer that when it isn't needed for BC (like this, this is a new=0A=
> API).=0A=
=0A=
I hadn't thought about that - that seems reasonable since I don't remember =
anything else adding indexOf as a method name.=0A=
=0A=
> - `contains` also doesn't have a comparator.=0A=
=0A=
I was considering proposing `->any(callable)` and `->all(callable)` extensi=
ons if this passed.=0A=
I'm not quite sure what you mean by a comparator for contains. There'd have=
 to be a way to check if a raw closure is contained.=0A=
=0A=
> -=A0 Similarly but less strongly, I don't like the filter callable=0A=
> returning `mixed` -- please just make it `bool`.=0A=
=0A=
The filter callable is something that would be passed into the filter funct=
ion. The return value would be checked for truthiness.=0A=
The phpdoc in the documentation could be changed, but that wouldn't change =
the implementation.=0A=
=0A=
> - I don't know what `setSize(int $size)` does. What does it do if the=0A=
> current size is less than `$size`? What about if its current size is=0A=
> greater? I suspect this is about capacity, not size, but without docs=0A=
 > I am just guessing.=0A=
=0A=
It's the same behavior as https://www.php.net/manual/en/splfixedarray.setsi=
ze.php . It's about size, not capacity.=0A=
=0A=
> Change the size of an array to the new size of size.=0A=
> If size is less than the current array size, any values after the new siz=
e will be discarded.=0A=
> If size is greater than the current array size, the array will be padded =
with null values.=0A=
=0A=
I'd planned to add phpdoc documentation and examples before starting a vote=
 to document the behavior and thrown exceptions of the proposed methods.=0A=
=0A=
Thanks,=0A=
Tyson=