Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:116045 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 14662 invoked from network); 15 Sep 2021 17:20:06 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 15 Sep 2021 17:20:06 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 80B221804B2 for ; Wed, 15 Sep 2021 10:59:37 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 15 Sep 2021 10:59:36 -0700 (PDT) Received: by mail-lf1-f52.google.com with SMTP id bq5so7662223lfb.9 for ; Wed, 15 Sep 2021 10:59:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qP20mfaz+4yZLTiipXP0m9H8EeYf9E4YmYfWQ0Lm0z4=; b=ha+pPEHTs0J2pr5HQbbzg6LUlRdyiBLs+OxM61567blcIswQC9pdIbf1qeF5P+DXEK yLIslMpiyPrTXYWwZqJ2b6b1E+2cCF5xhm6ZuGP3ESQBfac0Nx+htI+ELrwxVPbxRhzU Fjyl2IIqIMgLAxylM61JkwsGKIdswCfSjVlfNqioxCAdRLjreDp4sO7o3sN8+B3Vehl1 t9RWEx32tIeHH3TDqAqcxkBjEEk39P8hNL4hjVRSXe+HjWQduBfPrAZKeAZNvFknQJs8 SvIBDXqICcfK14YtRV4jjpk13QHtUrayJX50D49WRJZbWKbYtZviQ7SSMqat2xaVePBC GRBw== X-Gm-Message-State: AOAM533ltmOHtq5BT7Xf7R2yvzyot5k/jvKn9GWWvTP0+NaAZfDRgap7 NC6h6zs7YZvVTqvg1orZpm9FxzJ11yJmhqR0KjKKlQ== X-Google-Smtp-Source: ABdhPJyDXWYtVKTgRmo2Zc9qsX5BVNT3isi8Vt5Ep0axU8efxRhf04iZbnWZxJNt3L+3DLe8myzov1rylZoNm8yMasU= X-Received: by 2002:a05:6512:3b2c:: with SMTP id f44mr928287lfv.662.1631728775335; Wed, 15 Sep 2021 10:59:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Wed, 15 Sep 2021 12:59:24 -0500 Message-ID: To: Jeremy Mikola Cc: PHP Internals Content-Type: multipart/alternative; boundary="00000000000006262305cc0c768a" Subject: Re: [PHP-DEV] run-tests SKIPIF caching can be problematic for third-party extensions From: pollita@php.net (Sara Golemon) --00000000000006262305cc0c768a Content-Type: text/plain; charset="UTF-8" On Wed, Sep 15, 2021 at 12:22 PM Jeremy Mikola wrote: > I just discovered that run-tests.php was changed to cache SKIPIF evaluation > since 8.1.0beta3[1]. I believe ext-mongodb ran into the same issue as > mysqli[2], as we use SKIPIF to check that database contents are clean going > into a test. The present solution in core is to check SKIPIF output for > "nocache" [3,4] and allow individual tests to opt out of caching; however, > I'm worried that won't be portable for third-party extensions, where we > test with run-tests.php for each version of PHP that we support. > > If the phpt file outputs "skip nocache" then that will skip without caching on all versions, won't it? In 8.1 because it has the explicit 'nocache' provided, and in older versions because they don't cache anyway. Am I missing something? -Sara --00000000000006262305cc0c768a--