Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:116044 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 11864 invoked from network); 15 Sep 2021 16:43:17 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 15 Sep 2021 16:43:17 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 91C061804CF for ; Wed, 15 Sep 2021 10:22:46 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 15 Sep 2021 10:22:46 -0700 (PDT) Received: by mail-io1-f41.google.com with SMTP id n24so4417712ion.10 for ; Wed, 15 Sep 2021 10:22:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=coFgKXDal5wUB7HekRt78PB2Kh/mnfOdJWlU+20yM2o=; b=fHR6ux5W2sOwhOQSpFOVYJvSbnjoBshwm5Vo94dXIxDd2btekAj+9uVdtv+PSzdEPW IT7QcFmvyzkEeLhpe5B7uLQBqYgqjaDNg8PNPIkQehlxB1MeRHZd3875iUZ1hSatoQqd mkRE9/t1azqXFQUEBJrFvEdVyvVz9hiey6L7YaX7AHsggf2/Lc/DBVSUWvUp6Q2ebasi 3CVhadvrvoJkru6I9UQF7xJyTQA4+o3mt8s8Be9XhZQFzG0N2in0p0CLYrprqvAIznMA YCwYehiOieQMDpBLKop9MmesitjwlGopElS8+3y4EcNFJrBKabUc1yKJrhrKEjtzJgsy qM0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=coFgKXDal5wUB7HekRt78PB2Kh/mnfOdJWlU+20yM2o=; b=dCl/DOkLUkqawlU1FKPi2QDNRjzQn9BbFMvg8gw5qHV3u/Ur5LEiDBGwtFTRVRIcBH Hg3NFfEwls500DshNQL1H+oBeY50G+ARHXqo5Hzl/yWSBC/5KoyRV07zCZ5tDoOXi8qR Y7+St6p2Lr4/LSS0ttobXj/+lTfbKS4BSnwh+xopXjzA+2O17TlSIk2Iq42H1EX4XwBC 4dpztJaYzZir1LBeYEhnzf2UveooCSmnTu16xMVCJ/jSJ5fvfRVo1kOrFS3AL5U5846L d588+P0kgcXRQ/VxEP/+tuw+H1rNU66AJD/GHjCN1yoPNr1slACjJJZgazKWetKr/YLx X81Q== X-Gm-Message-State: AOAM531p9CgaNDEkAkRDmGHjjNZkCB4ARuIOGkUmuXEIMpriFE90m08P Ez0X41T6X2hP63wVrjSTPnN5YJ6Hq5FYvvH7Ewaxyrz+Zbw= X-Google-Smtp-Source: ABdhPJwgnQQI/3D8QEPvSlcQHUQYt6tp30/acXiWxtP/daIepEpe3IwlmDC+nIi83DuzEF7vc1J7lw7WqhKisZv7l2w= X-Received: by 2002:a6b:e70f:: with SMTP id b15mr964730ioh.140.1631726563032; Wed, 15 Sep 2021 10:22:43 -0700 (PDT) MIME-Version: 1.0 Date: Wed, 15 Sep 2021 13:22:32 -0400 Message-ID: To: PHP Internals Content-Type: multipart/alternative; boundary="00000000000029024405cc0bf269" Subject: run-tests SKIPIF caching can be problematic for third-party extensions From: jmikola@gmail.com (Jeremy Mikola) --00000000000029024405cc0bf269 Content-Type: text/plain; charset="UTF-8" I just discovered that run-tests.php was changed to cache SKIPIF evaluation since 8.1.0beta3[1]. I believe ext-mongodb ran into the same issue as mysqli[2], as we use SKIPIF to check that database contents are clean going into a test. The present solution in core is to check SKIPIF output for "nocache" [3,4] and allow individual tests to opt out of caching; however, I'm worried that won't be portable for third-party extensions, where we test with run-tests.php for each version of PHP that we support. Is there still time to consider an alternative solution? If "nocache" needs to remain in place for mysqli, perhaps 8.1.0's run-tests.php can be enhanced to consult an environment variable (for maximum BC and playing nice with `make test`) that disables caching entirely. [1]: https://github.com/php/php-src/pull/6681 [2]: https://github.com/php/php-src/pull/6726 [3]: https://github.com/php/php-src/commit/4d43cbe333690171753e9b8663df93d3762e02a8 [4]: https://github.com/php/php-src/commit/0074a1d4e3a85d0d63118e7a30f4b7ed6da64695 -- jeremy mikola --00000000000029024405cc0bf269--