Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116043
MIME-Version: 1.0
References: <CAFv4g+HRHrvCOTgpbVfCXj06De1kL+1+RwnGgq6tcyLNAtLfQA@mail.gmail.com>
 <CAFv4g+Fs-iSHoykGhkzzJFZSd=UDB9ZGEq-aeo0VyPjqrppQKw@mail.gmail.com>
 <CAFv4g+EwnJakuMyG5S2pUDLQSno+sRxybhGf=b5x8SappExd=w@mail.gmail.com>
 <BC03D9F6-E782-4AF8-A0FE-92287DC5F430@gmail.com> <38D62556-3073-4B42-9D39-651136A09C80@koalephant.com>
In-Reply-To: <38D62556-3073-4B42-9D39-651136A09C80@koalephant.com>
Date: Tue, 14 Sep 2021 15:53:21 +0100
Message-ID: <CAFv4g+FB9DFjpqx_AEooRB3Trr9=usfCOCWAHoQHrypWpschug@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000fa85ff05cbf5be61"
Subject: Re: [PHP-DEV] [RFC] [VOTE] is_literal
From: craig@craigfrancis.co.uk (Craig Francis)

--000000000000fa85ff05cbf5be61
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 8 Sept 2021 at 09:32, Stephen Reay <stephen@koalephant.com> wrote:

> I had my share of issues with Craig=E2=80=99s PR, but I think the origina=
l goal of
> it was a good and useful concept



Thanks Stephen,

Just to confirm to others on-list... your "share of issues" was when we
looked at allowing all Integers, and you "would have been happy with
original/final implementation with strings only"... also, I agree with "A
type hint would be a great addition too".

For those who missed the original discussion... unlike strings, we cannot
flag if an integer was defined by the developer (in the PHP script); and
because integers cannot cause Injection Vulnerabilities (the pure
definition), I decided to allow all integers (to help adoption). But, with
my naming mistake (trying to better reflect that behaviour), and people
finding it a messy concept, we ended up removing integer support.

Craig

--000000000000fa85ff05cbf5be61--