Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116043
Return-Path: <craig@craigfrancis.co.uk>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 9915 invoked from network); 14 Sep 2021 14:14:22 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 14 Sep 2021 14:14:22 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id 060061804B3
	for <internals@lists.php.net>; Tue, 14 Sep 2021 07:53:37 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,
	RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.2
X-Spam-ASN: AS15169 209.85.128.0/17
X-Spam-Virus: No
X-Envelope-From: <craig@craigfrancis.co.uk>
Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Tue, 14 Sep 2021 07:53:36 -0700 (PDT)
Received: by mail-lf1-f49.google.com with SMTP id k4so29424429lfj.7
        for <internals@lists.php.net>; Tue, 14 Sep 2021 07:53:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=craigfrancis.co.uk; s=default;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
        bh=9X/XHGqEYSFo2t8Coa/QHxaFCsR5vvwnp8gdFBjplnY=;
        b=f1ZwPKiXxvwtPazn1tlkqG56AG6Hcr6cgArf01mHdkEDB6TBul1yAgd4tuY+bLSvBi
         1egyQ0g9SPRQjKPiRr1IUUujH63nXQMJNmZaTyJ+AAk1WSsbLNtNS+MW0BIZ3iw05UQq
         R2wefYaMoBPYSKGZxlQ/zDaxnh29FNLFxc9bw=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to;
        bh=9X/XHGqEYSFo2t8Coa/QHxaFCsR5vvwnp8gdFBjplnY=;
        b=FABHSPfESFCYX1Om/PhXLiX78M8d0blWSxUGue8yK72uuH7LQeZPzWbW2RXnqdFm3B
         ESGOfeQ4PGqIJ6a38i7G5r9BY4UStYF7DrVyxgY8J/k72Uy86IRsCrh2c24VtbbxvboU
         4YqOhfyPJVdox0U0D68QmIhG7pGc0nkL6DBnnADBXIYjSNikqYqe0ZamvX1XoXRLdgSk
         0BfEzVGOZ273P4QILMHkCxOLsENjxaLoARiL8qtnBDl6Kcz4zda/M5GCUyt/8eOb+yjz
         kzuUsoOkn9TeUhGyxEVIUL7XjWv6AwrSAjQi1+vOdYs5SPX7iwqgzYq1GkKCWnN6R6Qn
         rQsg==
X-Gm-Message-State: AOAM531HBk+d+P/Us5fRXr2l+BZdLa7GSSJLYt2wmMQni+JUf4Bq8mcb
	qv673g0KDhqLYje1PBFJMqxc2stzX3XVPlZC6fEOAS5Fk2I=
X-Google-Smtp-Source: ABdhPJxo+jfT7sxwA1yW+v9XOpWRBH+9ebWBocq/p6e3yIj/B+PWQwoyrubR/Yr1kr7biBv32di6FZVuq2ZocXyuKjE=
X-Received: by 2002:a05:6512:3da5:: with SMTP id k37mr13688194lfv.655.1631631215061;
 Tue, 14 Sep 2021 07:53:35 -0700 (PDT)
MIME-Version: 1.0
References: <CAFv4g+HRHrvCOTgpbVfCXj06De1kL+1+RwnGgq6tcyLNAtLfQA@mail.gmail.com>
 <CAFv4g+Fs-iSHoykGhkzzJFZSd=UDB9ZGEq-aeo0VyPjqrppQKw@mail.gmail.com>
 <CAFv4g+EwnJakuMyG5S2pUDLQSno+sRxybhGf=b5x8SappExd=w@mail.gmail.com>
 <BC03D9F6-E782-4AF8-A0FE-92287DC5F430@gmail.com> <38D62556-3073-4B42-9D39-651136A09C80@koalephant.com>
In-Reply-To: <38D62556-3073-4B42-9D39-651136A09C80@koalephant.com>
Date: Tue, 14 Sep 2021 15:53:21 +0100
Message-ID: <CAFv4g+FB9DFjpqx_AEooRB3Trr9=usfCOCWAHoQHrypWpschug@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000fa85ff05cbf5be61"
Subject: Re: [PHP-DEV] [RFC] [VOTE] is_literal
From: craig@craigfrancis.co.uk (Craig Francis)

--000000000000fa85ff05cbf5be61
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 8 Sept 2021 at 09:32, Stephen Reay <stephen@koalephant.com> wrote:

> I had my share of issues with Craig=E2=80=99s PR, but I think the origina=
l goal of
> it was a good and useful concept



Thanks Stephen,

Just to confirm to others on-list... your "share of issues" was when we
looked at allowing all Integers, and you "would have been happy with
original/final implementation with strings only"... also, I agree with "A
type hint would be a great addition too".

For those who missed the original discussion... unlike strings, we cannot
flag if an integer was defined by the developer (in the PHP script); and
because integers cannot cause Injection Vulnerabilities (the pure
definition), I decided to allow all integers (to help adoption). But, with
my naming mistake (trying to better reflect that behaviour), and people
finding it a messy concept, we ended up removing integer support.

Craig

--000000000000fa85ff05cbf5be61--